Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that untyped values are converted to the same type #1677

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

secDre4mer
Copy link
Contributor

This fixes an issue where two untyped values with different itype could not be operated on.

Minimal example to reproduce this:

package main

import "math"

func main() {
	println(math.MaxFloat64 - 1.0)
}

Result: invalid operation: mismatched types untyped float64 and untyped float, but should be 1.7976931348623157e+308

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
All committers have signed the CLA.

@secDre4mer secDre4mer changed the title feat: ensure that untyped values are converted to the same type fix: ensure that untyped values are converted to the same type Jan 6, 2025
Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thank you for this contribution.

@mvertes mvertes added bug Something isn't working area/core labels Jan 8, 2025
@mvertes mvertes merged commit 1e3e91d into traefik:master Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants