-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create render_jsonapi_test.rb #110
Open
chadwtaylor
wants to merge
1
commit into
trailblazer:master
Choose a base branch
from
chadwtaylor:patch-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
require 'test_helper' | ||
|
||
class RenderTest < ActionController::TestCase | ||
include Roar::Rails::TestCase | ||
|
||
class SingersController < ActionController::Base | ||
|
||
module SingerRepresenter | ||
include Roar::JSON::JSONAPI | ||
# type :musicians | ||
property :name, :as => :title | ||
end | ||
|
||
module SingersRepresenter | ||
include Representable::JSON::Collection | ||
self.represenation_wrap = :musicians | ||
items :extend => PersonRepresenter | ||
end | ||
|
||
include Roar::Rails::ControllerAdditions | ||
include Roar::Rails::ControllerAdditions::Render | ||
|
||
# NOTE: using :json_api will break | ||
represents :json, :entity => SingerRepresenter, :collection => SingersRepresenter | ||
|
||
def show | ||
singer = Musician.new("Bumi") | ||
render :json => singer, status: 201 | ||
end | ||
|
||
def index | ||
singers = [Musician.new("Bumi"), Musician.new("Iggy")] | ||
render :json => singers, status: 201 | ||
end | ||
|
||
end | ||
|
||
tests SingersController | ||
|
||
test "should use Representer for #render using jsonapi on a single model" do | ||
get :show, :id => "bumi", :format => :json_api | ||
assert_equal response.body, '{"musicians":{"title":"Bumi"}}' | ||
assert_equal 201, response.status | ||
end | ||
|
||
test "should use Representer for #render using jsonapi on a model collection" do | ||
get :index, :format => :json_api | ||
assert_equal response.body, '{"musicians":[{"title":"Bumi"},{"title":"Iggy"}]}' | ||
assert_equal 201, response.status | ||
end | ||
|
||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want that? Both entities and collections must be rendered with the "same" representer using JSONAPI - this is a media format specification and not up to you. So, there should be no need to declare the
:collection
representer here, this must be sorted internally.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the
:collection
would throw this error:NameError: uninitialized constant RenderTest::SingersRepresenter
. So I had to bake that in to make it work.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, for further contributions, keep in mind that you don't have to make tests work with hacks. For the author, it's even better if you submit breaking tests so they can see what's missing. It's actually my favourite PR style when people simply add a broken test.
Thanks, I'm pushing soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, that's the thing I didn't realize
:collection
was a hack... mostly because I'm not as into the Roar project as you are and you know what should work and when. Thanks for the tip and will definitely keep that in mind to provide broken tests! :)