Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Support verifing *.slsa.attestation attestation files #86

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

facutuesca
Copy link
Collaborator

@facutuesca facutuesca commented Jan 14, 2025

The CLI subcommand pypi-attestations verify attestation now detects also *.slsa.attestation files during verification. If both publish and SLSA attestations are present, both are verified:

pypi-attestations verify attestation  \
  --identity https://github.com/trailofbits/pypi-attestations/.github/workflows/release.yml@refs/tags/v0.0.19 \
  test/assets/pypi_attestations-0.0.19.tar.gz

OK: test/assets/pypi_attestations-0.0.19.tar.gz.publish.attestation
OK: test/assets/pypi_attestations-0.0.19.tar.gz.slsa.attestation

@facutuesca facutuesca force-pushed the ft/support-slsa-attestations branch 5 times, most recently from d94d175 to f98ed55 Compare January 14, 2025 22:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Facundo Tuesca <[email protected]>
Signed-off-by: Facundo Tuesca <[email protected]>
@facutuesca facutuesca force-pushed the ft/support-slsa-attestations branch from f98ed55 to 5e585e9 Compare January 14, 2025 22:22
@facutuesca facutuesca requested a review from woodruffw January 14, 2025 22:25
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @facutuesca!

@woodruffw woodruffw merged commit 28d055e into main Jan 14, 2025
7 checks passed
@woodruffw woodruffw deleted the ft/support-slsa-attestations branch January 14, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants