-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass removal of version switches #102
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalster
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehwenk
pushed a commit
that referenced
this pull request
Nov 19, 2024
As discussed in issue #92, the goal of this upgrade was to: 1. Discontinue support for AusTraits version < 4.2.0 - Mass removal of switch functions that controlled function behaviour depending on AusTraits version (Issue #102, issue #91) - Creation of check_compatibility() (Issue #100) - Console messaging alerting user which version of AusTraits is supported by which functions (Issue #100) - Updated documentation guiding user on how to install an older version of the R package for backwards compatibility (Issue #93) 2. Introduce new traits.build 'wrangling output' functions into austraits - flatten_database added to austraits (Issue #105) - bind_databases added to austraits (Issue #106) 3. Reduce redundancy across traits.build and austraits to streamline codebase maintenance - plot_trait_beeswarm moved back to austraits - trait_pivot_ moved back to austraits 4. Refactor {austraits} functions to support other traits.build databases and allow functionality across more tables and columns. - join_ functions (Issue #91) - extract_ functions (Issue #107) - Rename argument names (Issue #115) 5. Update documentation accordingly - Pointing to APD and traits.build-book directly in README and vignette Update documentation in {austraits} for changes in version 3.0.0 #96 Update documentation with reference to manual #74 Added cheatsheet ________________________ co-authored by @ehwenk and @dfalster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #91
Removal of switches
extract_*
trait_pivot_wider
join_*
plot_locations
plot_trait_beeswarm
as_wide_table
Changes to existing functions
plot_locations
andtrait_pivot_wider
now accepts either traits table ORtraits.build
list objectsummarise_trait_means
will trigger warning due to uninformed calculation of means.Deprecations
plot_site_locations
andtrait_pivot_longer
are deprecatedAddition of helper functions to assist with removal of switches