Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating print function and messaging style #122

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Updating print function and messaging style #122

merged 10 commits into from
Nov 14, 2024

Conversation

fontikar
Copy link
Collaborator

Addresses #115

  • S3 class is now 'traits.build' not 'austraits'
  • print function is now print.traits.build
  • Switched to cli for nicer printing of database and package start up message.
  • Renamed summarise_austraits to summarise_database (updated tests accordingly), this was missed in Generalise argument names for all functions in {austraits} #111

@fontikar fontikar changed the base branch from master to develop November 14, 2024 05:36
@fontikar fontikar requested review from dfalster and ehwenk November 14, 2024 05:37
dfalster
dfalster approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@fontikar fontikar merged commit f16e41e into develop Nov 14, 2024
5 checks passed
@fontikar fontikar deleted the generic branch November 14, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfalster dfalster dfalster approved these changes

@ehwenk ehwenk Awaiting requested review from ehwenk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontikar @dfalster