-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #29: use Tini (offiically supported by Docker) to reap defunct glusterfs processes. #30
Conversation
…unct glusterfs processes.
130ccfe
to
6d931e3
Compare
Tested it, works with familiar situation. |
If there’s no activity here soon I can also fork the project and publish the fixed plugin on Docker hub myself if needed. |
@ximon18 Please fork. I haven't been able to make activity on this. |
Thanks @trajano, I'll do that. |
I built from sources and applied above patch and solve problem of defunct process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, tini solved defunct process
I still intend to do this, but with Covid-19 and other stuff I didn't get to it yet, and it's not as simple as just forking as I'd either want to split out the Gluster part from the other drivers (as I know nothing about them) or take them all on but then know how to build and test them, and as evidenced by the lack of activity on my part I wouldn't have been able to offer much until now in the way of active support for the project (I still depend on it and am happy to, the GlusterFS part at least, take it over). |
@ximon18 I am preparing a new patch which includes this one and another module to mount S3Fs filesystem (AWS S3 or Oracle Cloud Objects) using s3fs-fuse drivers which works similar to GlusterFS. |
Sounds excellent. sorry I haven't been able to work on this one anymore. (Too many other projects) but S3FS should be a good addition. I am waiting for moby/moby#39624 to be sort of having some progress before I go on back on this project. |
I am working with this branch https://github.com/marcelo-ochoa/docker-volume-plugins/tree/s3fs_support testing against Oracle Cloud Object storage which is S3 compatible. |
Merged and fixed in PR (#39). |
Fixes #29.