Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #29: use Tini (offiically supported by Docker) to reap defunct glusterfs processes. #30

Closed

Conversation

ximon18
Copy link

@ximon18 ximon18 commented Mar 7, 2020

Fixes #29.

@ximon18 ximon18 force-pushed the fix-29-defunct-glusterfs-processes branch from 130ccfe to 6d931e3 Compare March 7, 2020 21:49
@btheu
Copy link

btheu commented Mar 17, 2020

Tested it, works with familiar situation.

@ximon18
Copy link
Author

ximon18 commented Mar 17, 2020

If there’s no activity here soon I can also fork the project and publish the fixed plugin on Docker hub myself if needed.

@trajano
Copy link
Owner

trajano commented Mar 17, 2020

@ximon18 Please fork. I haven't been able to make activity on this.

@ximon18
Copy link
Author

ximon18 commented Mar 18, 2020

Thanks @trajano, I'll do that.

@marcelo-ochoa
Copy link
Collaborator

I built from sources and applied above patch and solve problem of defunct process.
Thanks a lot @ximon18 !!

Copy link
Collaborator

@marcelo-ochoa marcelo-ochoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, tini solved defunct process

@ximon18
Copy link
Author

ximon18 commented Sep 29, 2020

@ximon18 Please fork. I haven't been able to make activity on this.

I still intend to do this, but with Covid-19 and other stuff I didn't get to it yet, and it's not as simple as just forking as I'd either want to split out the Gluster part from the other drivers (as I know nothing about them) or take them all on but then know how to build and test them, and as evidenced by the lack of activity on my part I wouldn't have been able to offer much until now in the way of active support for the project (I still depend on it and am happy to, the GlusterFS part at least, take it over).

@marcelo-ochoa
Copy link
Collaborator

@ximon18 I am preparing a new patch which includes this one and another module to mount S3Fs filesystem (AWS S3 or Oracle Cloud Objects) using s3fs-fuse drivers which works similar to GlusterFS.
Marcelo.

@trajano
Copy link
Owner

trajano commented Sep 29, 2020

Sounds excellent. sorry I haven't been able to work on this one anymore. (Too many other projects) but S3FS should be a good addition.

I am waiting for moby/moby#39624 to be sort of having some progress before I go on back on this project.

@marcelo-ochoa
Copy link
Collaborator

I am working with this branch https://github.com/marcelo-ochoa/docker-volume-plugins/tree/s3fs_support testing against Oracle Cloud Object storage which is S3 compatible.
I'll make a new PR ASAP.
Marcelo.

@marcelo-ochoa
Copy link
Collaborator

Merged and fixed in PR (#39).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker stop command create <defunct> process
4 participants