B-21488: UB Allowance Warning Main #14503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Was there an upstream to this at one point? Has it been merged in? @TevinAdams
traskowskycaci
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Thanks for adding that upstream link back in, looks good there
Seeing an extra commit in this main PR that I don't see an equivalent change for in the integrationTesting branch
commit: 94b1504
@traskowskycaci It has been removed |
traskowskycaci
approved these changes
Jan 13, 2025
cameroncaci
approved these changes
Jan 13, 2025
danieljordan-caci
approved these changes
Jan 13, 2025
|
Possible defect identified - excess risk does not qualify a second time. Getting this double checked |
|
marking draft for now |
|
|
We're bringing it up again as a possible missed requirement during standup tomorrow since it wasn't acknowledged in the ticket and tester doesn't remember if it was POA'd |
|
Cleared for release |
|
flaky test failing |
|
flaky tests failing again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge After B-21675
B-21675 Main PR
Agility ticket
21488 INT PR 1
21488 INT PR 2
Summary
In this PR implementation is being added to evaluate excess weight for a UB shipment. Excess weight can be evaluated on shipments at 2 key points. When a shipment is approved and when a shipment is updated. On approval if the prime estimated weight exist then it will be evaluated. On update if the updated shipment has a prime estimated weight included.
For UB shipments, based on the AC of the story, when the primeEstimatedWeight or the primeActualWeight is within 10% or greater of the UBAllowance then excessWeight will be triggered until it has been acknowledged. Same flow of all other shipments.
Is there anything you would like reviewers to give additional scrutiny?
this article explains more about the approach used.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
3.Create a move using that address discussed above as one of the duty locations
Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
508 Compliance Check
