INT-B-21974 hide additional pickup and delivery options for nts and ntsr

[brianmanley-caci]

Agility ticket

Summary

This story is to improve the shipment creation UI in the Prime Simulator for NTS/NTSR shipments. NTS shipment can only have one delivery address. We are hiding the secondary delivery question which also logically hides the tertiary delivery question. This prevents the user from attempting to supply those addresses which would cause an error. The same thing is applied to secondary/tertiary pickup addresses for NTSR shipments which should only have a primary pickup address.

Verification Steps for the Author

These are to be checked by the author.

• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

How to test

NTS

1. Access the office application.
2. Login as a Prime Simulator user.
3. Select an existing move.
4. Click the Create Shipment button.
5. Select HHG_INTO_NTS for the shipment type.
6. Verify that the "Second Delivery Address" question does not display.
7. Enter all the required information.
8. Click the Save button.
9. You should receive a success message that you're shipment was created.
10. Logout of the application.
11. Log back in as a TOO user.
12. Search by the Move code of the shipment you just created.
13. Verify that you can see the newly created NTS shipment

NTSR

1. Access the office application.
2. Login as a Prime Simulator user.
3. Select an existing move.
4. Click the Create Shipment button.
5. Select HHG_OUTOF_NTS_DOMESTIC for the shipment type.
6. Verify that the "Second Pickup Address" question does not display.
7. Enter all the required information.
8. Click the Save button.
9. You should receive a success message that you're shipment was created.
10. Logout of the application.
11. Log back in as a TOO user.
12. Search by the Move code of the shipment you just created.
13. Verify that you can see the newly created NTSR shipment

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[brianmanley-caci]

Converting to draft temporarily while I pull in the NTSR shipment type name change.

[brianmanley-caci]

Converting to draft temporarily while I pull in the NTSR shipment type name change.

Ok, I got the NTSR name change pulled in. This is ready for review.

[msaki-caci]

lgtm. Got it running locally. One question though are the changes coming in from .gitlab-ci.yml from main?

[brianmanley-caci]

lgtm. Got it running locally. One question though are the changes coming in from .gitlab-ci.yml from main?

Yep. If you compare the file contents to what's in main, it should match up.

[msaki-caci]

lgtm. Got it running locally. One question though are the changes coming in from .gitlab-ci.yml from main?

Yep. If you compare the file contents to what's in main, it should match up.

In hindsight I could have just done that myself instead of commenting 😅

[brianmanley-caci]

lgtm. Got it running locally. One question though are the changes coming in from .gitlab-ci.yml from main?

Yep. If you compare the file contents to what's in main, it should match up.

In hindsight I could have just done that myself instead of commenting 😅

lol no worries.