B 22186

[r-mettler]

B-22186

INT PR

Summary

There have been errors occurring in production when documents are deleted and then new documents uploaded. This would occur when attempting to download the AOA Packets. The method used to fetch the uploaded documents by the AOA packet creation was passing a flag that in certain situations (that are difficult to reproduce) would cause the query for documents to return empty even though there are uploaded documents for that shipment. To resolve this we tell the query to give us everything then filter out the deleted uploads inside the AOA creation method.

The following was the error I received during analysis and that is seen in production:
"error creating AOA packet: error building PDF batch information for bookmark generation for order docs: error fetching document domain by id: e0817df2-f271-41ff-866a-e197328c0d6f: FETCH_NOT_FOUND"}

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

This one was tricky to get it to fail but the basic idea was to add a bunch of order documents then delete them then add them again and request an advance for the PPM so you can attempt to download the AOA packet.

1. Create a new Customer
2. Upload your Order then delete and upload again, I did this a few times and also clicked the back button and left the screen then came back in and upload 2 or 3 documents.
3. Create a PPM shipment
4. Ask for an advance
5. Submit the PPM
6. Login as a SC
7. Approve the shipment
8. Download the AOA packet verify no errors
9. Login as the Customer
10. Download the AOA packet verify no errors

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[antgmann]

Matches ✅

[r-mettler]

Matches ✅