-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT-B-22239 show deleted agent in move history #14653
Merged
brianmanley-caci
merged 14 commits into
integrationTesting
from
INT-B-22239-Show-Deleted-Agent-In-Move-History
Jan 24, 2025
Merged
INT-B-22239 show deleted agent in move history #14653
brianmanley-caci
merged 14 commits into
integrationTesting
from
INT-B-22239-Show-Deleted-Agent-In-Move-History
Jan 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAIN-B-21618 Prime Sim Create NTS/NTSR Shipments
MAIN B-21708
brianmanley-caci
added
INTEGRATION
Slated for Integration Testing
Go-Rillaz
Go-Rillaz
labels
Jan 24, 2025
brianmanley-caci
requested review from
danieljordan-caci,
brooklyn-welsh,
traskowskycaci,
antgmann,
elizabeth-perkins,
samaysofo,
msaki-caci,
ryan-mchugh and
stevengleason-caci
January 24, 2025 15:06
ryan-mchugh
approved these changes
Jan 24, 2025
🦛 ✅ |
antgmann
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brianmanley-caci
deleted the
INT-B-22239-Show-Deleted-Agent-In-Move-History
branch
January 24, 2025 18:38
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agility ticket
Summary
Currently when a Releasing/Receiving Agent is deleted from a shipment, the Move history shows only that the shipment was updated. It does not indicate anything regarding the deletion of the agent. This is not very helpful in knowing what action occurred on the shipment. To make the history of deleting agents more helpful, we are adding logic to 1) indicate that an agent was deleted 2) display the deleted agent's information.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Additionally, feel free to make updates to an agent such as changing the name, email, phone fields and verify the history still shows the changes for that update correctly.
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Screenshots
Example of the current UI for deleted agent (not very helpful)
Added Agents
Move history after deleting agents displays helpful information