Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-22239 show deleted agent in move history #14653

Conversation

brianmanley-caci
Copy link
Contributor

Agility ticket

Summary

Currently when a Releasing/Receiving Agent is deleted from a shipment, the Move history shows only that the shipment was updated. It does not indicate anything regarding the deletion of the agent. This is not very helpful in knowing what action occurred on the shipment. To make the history of deleting agents more helpful, we are adding logic to 1) indicate that an agent was deleted 2) display the deleted agent's information.

Verification Steps for the Author

These are to be checked by the author.

  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Login to the office application as a TOO or Services Counselor.
  2. Navigate to a move.
  3. Click Edit shipment on any shipment.
  4. Add a Releasing Agent and a Receiving Agent.
  5. Save the Shipment.
  6. Edit the shipment again.
  7. Delete the first name, last name, phone, and email for the Releasing and Receiving Agents.
  8. Save the shipment.
  9. Click on the Move history.
  10. Verify that the shipment has 2 rows indicating that the agent was deleted from the shipment.
  11. Verify that the now deleted agent's information is displayed.

Additionally, feel free to make updates to an agent such as changing the name, email, phone fields and verify the history still shows the changes for that update correctly.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Screenshots

Example of the current UI for deleted agent (not very helpful)

Screenshot 2025-01-24 at 8 39 38 AM

Added Agents

Screenshot 2025-01-24 at 8 48 24 AM
Screenshot 2025-01-24 at 8 48 51 AM

Move history after deleting agents displays helpful information

Screenshot 2025-01-24 at 8 51 12 AM

@ryan-mchugh
Copy link
Contributor

Local testing - verified

image

@antgmann
Copy link
Contributor

🦛 ✅

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shows editing nicely as well. Looks good! image

@brianmanley-caci brianmanley-caci merged commit 6c69f1c into integrationTesting Jan 24, 2025
35 checks passed
@brianmanley-caci brianmanley-caci deleted the INT-B-22239-Show-Deleted-Agent-In-Move-History branch January 24, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go-Rillaz Go-Rillaz INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants