Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21966 add rejected admin int #14694

Open
wants to merge 111 commits into
base: integrationTesting
Choose a base branch
from

Conversation

KonstanceH
Copy link
Contributor

@KonstanceH KonstanceH commented Jan 30, 2025

B-21966

Summary

This PR adds:

  1. The Rejected Office users view on the admin page.
  2. rejected_on columns to the office users table
  3. The ability to search by transportation office and role.

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

How to test

  1. Go to Office Users login page.*
  2. Click "Request Account" fill out necessary info and click submit.
  3. Go to Admins Page http://adminlocal:3000/system.
  4. Create new admin user if none available.
  5. Find requested account.
  6. Give it a rejection reason and reject.
  7. Go to "Rejected Users" tab and confirm that you see these fields:
    “email, first name, last name, Transportation Office, status, reason for rejection, rejected on, roles requested”
  8. Confirm that you can sort by the header's columns

*Can use RejectedOfficeUser and RequestedOfficeUser testharness to make needed users

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

Rejected users Page with partial columns

Screenshot 2025-02-11 at 9 56 06 PM

Rejected users Page with remaining columns sorted by roles

Screenshot 2025-02-19 at 11 37 16 AM

Search by transportation office and role

Screenshot 2025-02-19 at 1 14 25 PM Screenshot 2025-02-19 at 1 14 47 PM

@KonstanceH KonstanceH self-assigned this Jan 30, 2025
@KonstanceH KonstanceH added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Jan 30, 2025
@robot-mymove
Copy link

robot-mymove commented Jan 30, 2025

Warnings
⚠️

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?

View the frontend file org ADR for more information

Generated by 🚫 dangerJS against 88a3faf

@KonstanceH KonstanceH marked this pull request as ready for review January 30, 2025 14:26
@KonstanceH KonstanceH requested review from a team as code owners January 30, 2025 14:26
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I just finished some work for the requested office users and searching by transpo office (which is a requirement for this feature as well I see) and ran into searching nested object values through FetchMany not being possible. Had to refactor.

Could you look at this PR and see how I did the list function and copy that over (except for change the status from REQUESTED to REJECTED)? I just don't want the next dev to have to refactor it when it could be tackled in this one.

Also, I don't think you need the deleted_on column. We are hard deleting users, not soft.

Thoughts? Def welcome to hear them!

Copy link
Contributor

@JamesHawks224 JamesHawks224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing: success
code: looks good, but have comments

Makefile Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
JonSpight and others added 29 commits February 18, 2025 18:02
B 21439 main (B-21438 has to go first)
B-21551 estimated prices now calculates for NTS-R shipments
B 21339 main Bulk assignment modal: UI Layout and populate data (SC/TOO)
…est-calculations-BE

MAIN - B-22020 - TIO payment request calculations -BE
Main B-21985 counseling fee final payment review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.