-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21966 add rejected admin int #14694
base: integrationTesting
Are you sure you want to change the base?
Conversation
…arness and add ui.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I just finished some work for the requested office users and searching by transpo office (which is a requirement for this feature as well I see) and ran into searching nested object values through FetchMany
not being possible. Had to refactor.
Could you look at this PR and see how I did the list function and copy that over (except for change the status from REQUESTED
to REJECTED
)? I just don't want the next dev to have to refactor it when it could be tackled in this one.
Also, I don't think you need the deleted_on
column. We are hard deleting users, not soft.
Thoughts? Def welcome to hear them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing: success
code: looks good, but have comments
B 21439 main (B-21438 has to go first)
changed debian:stable image
B-21551 estimated prices now calculates for NTS-R shipments
B 21339 main Bulk assignment modal: UI Layout and populate data (SC/TOO)
…est-calculations-BE MAIN - B-22020 - TIO payment request calculations -BE
Main B-21985 counseling fee final payment review
B-21966
Summary
This PR adds:
rejected_on
columns to the office users tableVerification Steps for Reviewers
These are to be checked by a reviewer.
How to test
http://adminlocal:3000/system
.“email, first name, last name, Transportation Office, status, reason for rejection, rejected on, roles requested”
*Can use
RejectedOfficeUser
andRequestedOfficeUser
testharness to make needed usersFrontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots
Rejected users Page with partial columns
Rejected users Page with remaining columns sorted by roles
Search by transportation office and role