B 20636 MAIN - #26 Dependency Scan (Severity High) - ip 2.0.1 (DEV) #14700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlusk
requested review from
MInthavongsay,
antgmann,
r-mettler and
CoryKleinjanCACI
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
🦛 ✅ |
|
Updated comment to fix broken link |
r-mettler
approved these changes
Feb 3, 2025
|
🦛 ♻️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-20636
INT PR
Summary
Updates Storybook from 7.6.7 to 7.6.20 to remove the problematic dependency [email protected].
[email protected] removed ip as a dependency for the same security reason we want to.
Storybook is now on v8. Upgrading to 8.5.0 might be something to consider eventually but from my initial test it seems it will have a lot of side effects or at least a couple other packages that depend on storybook will need to be upgrades as well like
happo-plugin-storybookandeslint-plugin-storybook. Messing with that seems outside the scope of resolving this security finding.Summary
Updates Storybook from 7.6.7 to 7.6.20 to remove the problematic dependency [email protected].
[email protected] removed ip as a dependency for the same security reason we want to.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code
How to test
make storybookFrontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Backend
Database
Any new migrations/schema changes:
Screenshots