Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B 21348 INT bulk assignment save #14708

Merged
merged 64 commits into from
Feb 18, 2025

Conversation

loganwc
Copy link
Contributor

@loganwc loganwc commented Jan 30, 2025

Agility ticket

Contains 20356 and 21339

Summary

Adds ability to bulk save moves

How to test

  1. Create a few moves at the same transportation office
  2. Create a couple office users at that transportation office
  3. Create an office user supervisor
  4. Click bulk assignment button
  5. assign some moves
  6. moves should update in queue with new assignments
  7. Do the same for all queues (TIO queue needs B-21844 first or you can use swagger-ui)

This now includes 22296

  1. Create multiple payment requests for the same move
  2. Login as TIO
  3. Assign yourself two one of the payment requests
  4. The queue should refetch and rerender showing you assigned to all payment requests for that move

@loganwc loganwc added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing labels Jan 30, 2025
@loganwc loganwc self-assigned this Jan 30, 2025
@robot-mymove
Copy link

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 8af727f

@ryan-mchugh
Copy link
Contributor

Some minor comments, will run locally and do a quick final review when resolved.

@ryan-mchugh
Copy link
Contributor

Getting 2 test failures for the bulk assignment modal

image

@loganwc
Copy link
Contributor Author

loganwc commented Feb 17, 2025

Getting 2 test failures for the bulk assignment modal

image

updated the tests accordingly 🫡

@ryan-mchugh
Copy link
Contributor

Local Testing

Counseling
image
image
image

TOO
NOTE - queue does not refresh when bulk assignment modal saved here
image
image
image
image

** TOO - Destination Requests ** - not part of AC, making sure you're aware button not visible here
image

** TIO **
NOTE - queue refreshes fine, but 1 extra assignment for a user
image
image

@loganwc
Copy link
Contributor Author

loganwc commented Feb 17, 2025

Local Testing

Counseling

TOO NOTE - queue does not refresh when bulk assignment modal saved here

** TOO - Destination Requests ** - not part of AC, making sure you're aware button not visible here

** TIO ** NOTE - queue refreshes fine, but 1 extra assignment for a user

SC only moves at the logged in users counseling office are available to assign.
TOO Destination queue is coming later
TIO all payment requests in a move are assigned to the same user aka 1 assignment.

looking into why TOO isn't reloading queue

@loganwc
Copy link
Contributor Author

loganwc commented Feb 18, 2025

Local Testing
Counseling
TOO NOTE - queue does not refresh when bulk assignment modal saved here
** TOO - Destination Requests ** - not part of AC, making sure you're aware button not visible here
** TIO ** NOTE - queue refreshes fine, but 1 extra assignment for a user

SC only moves at the logged in users counseling office are available to assign. TOO Destination queue is coming later TIO all payment requests in a move are assigned to the same user aka 1 assignment.

looking into why TOO isn't reloading queue

I'm unable to replicate the too queue not refreshing on my local

@ryan-mchugh
Copy link
Contributor

TIO - understood, did not realize 2 on the same move, so unintentionally verified B-22296.

I'll see about recreating TOO refresh.

@ryan-mchugh
Copy link
Contributor

Ok, spoke with Logan and he tracked down the TOO queue issue to some mis-ordering of params on the column function for the TableQueue

ryan-mchugh
ryan-mchugh previously approved these changes Feb 18, 2025
@loganwc loganwc merged commit 28b8aa5 into integrationTesting Feb 18, 2025
5 of 6 checks passed
@loganwc loganwc deleted the B-21348-INT-Bulk-Assignment-Save branch February 18, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

8 participants