B 22288 fix pdfcpu int

[cameroncaci]

B-22288

Summary

The pdfcpu config wasn't being passed to bookmarks, pdfcpu had hard-coded optimization, pdfcpu had another hidden config.yml file that can be fed into the app which I adjusted the defaults to set optimization to false. These have all been remedied, and now bookmarking will not be optimized (Which breaks things). The previous PR fixed the merging portion, this one fixes bookmarks, now all is dandy.

Pointed fork to the fixes.

Warning

Where are the pdfcpu code changes? Right here
https://github.com/transcom/pdfcpu/compare/83d2d75ad4cd..4b416bd62126

Setup to Run the Code

Important

You might have cached pdfcpu configs that could cause an issue during testing. You should only have to do this if you get testing issues.
Here are the two spots to delete it from:

1. rm "/Users/${USER}/Library/Application Support/pdfcpu/config.yml
2. Identify your golang tmp dir, easiest way is to serve in debug and put a breakpoint at pkg/paperwork/generator.go:121 to see the variable. Once you find it, rm ${tmp_dir}/pdfcpu/config.yml

How to test

1. As a customer make a PPM while using "Testing document.pdf" as the orders
2. Proceed through the PPM closeout flow until you're back as the customer uploading weight tickets
3. Upload weight ticket 1 as "outlines-with-loop.pdf"
4. Upload weight ticket 2 as "sample.pdf"
5. Finish closeout
6. Download payment packet, if it passes, it worked! The combination of outlines-with-loop.pdf and sample.pdf is a known crash.

sample.pdf
Testing Document.pdf
outlines-with-loop.pdf

Pdfcpu

Opened an issue with the pdfcpu maintainers pdfcpu/pdfcpu#1089

Test changes

Image extraction from PDF requires optimization to be enabled. I have verified the PDFs are still embedding properly by writing the file locally and previewing it (snippet below), as well as adjusting the test to check page count as an interim solution. The extract image from PDF is a func only used in our tests to validate file creation. This interim solution is a workaround until the pdfcpu optimization overflow error has been resolved.

[deandreJones]

did you make the changes in the transcom/pdfcpu or just suggesting the pdfcpu team to make the changes?

[cameroncaci]

did you make the changes in the transcom/pdfcpu or just suggesting the pdfcpu team to make the changes?

I made the changes in transcom/pdfcpu and will be suggesting them to the pdfcpu team

[deandreJones]

did you make the changes in the transcom/pdfcpu or just suggesting the pdfcpu team to make the changes?

I made the changes in transcom/pdfcpu and will be suggesting them to the pdfcpu team

the description mentioned the pdfpcr repo - is why I asked

[cameroncaci]

did you make the changes in the transcom/pdfcpu or just suggesting the pdfcpu team to make the changes?

I made the changes in transcom/pdfcpu and will be suggesting them to the pdfcpu team

the description mentioned the pdfpcr repo - is why I asked

Ah, whoops let me fix that

[cameroncaci]

Got a test to fix

[cameroncaci]

@deandreJones @danieljordan-caci see PR description "Test changes" for what changed since your last review