Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21416 intl crating tio update for payment request-FE #14766

Conversation

taeJungCaci
Copy link
Contributor

@taeJungCaci taeJungCaci commented Feb 6, 2025

B-21416

Summary

This is the FE portion of the implementation done on B-22020.
Displays international crating/uncrating service item payment request param information in TIO payment request review page.

Note: External crating is subject to 4 cubic ft min and all the others are not. Meaning if you select 'External Crate' option when creating the service item, it will charge as 4 cubic ft if the crate size is lower than that.

How to test

NOTE: So currently the crate size - cu ft is allowed 2 decimal places (ex. 0.01) which means it will calculate correctly if the dimensions are at least about 2.6 x 2.6 x 2.6 inches. If you put any lower size than this you will get a cu ft size of 0.00 which will result in $0 for the total amount.

  1. As a customer -> create any move with a iHHG shipment.
  2. As a SC -> edit and submit.
  3. As a TOO -> Approve and send to prime.
  4. As a Prime -> add service item to the shipment and choose International Crating on the dropdown.
  5. Fill out the form - make sure item size is less than the crating size and put 2600 for each L, W, H. Also choose external crate and 'standalone' option.
  6. Create another International crating service item, but this time don't choose the external crate or standalone option and put 2600 or greater for each L, W, H.
  7. Create 1 more service item - a International uncrating service item and put at least 2600 for each sizes.
  8. As a TOO -> approve these service items added.
  9. As a Prime -> Request payment for the service items.
  10. As a TIO -> review the payment request (may have to review weights first and approve).
  11. Verify the labels match and values are what you input:

If you have selected "External crate" option for International Crating and have chosen dimensions that is less than 4 cu ft, that you should see Crating size (cu ft) - Minimum 4.00, Actual size, External crate, and Minimum crating size applied labels.

You should also see OCONUS label for ICRT if your pickup address is OCONUS. Otherwise CONUS.
You should also see OCONUS label for IUCRT if your destination address is OCONUS. Otherwise CONUS.

  1. Check the screenshots to compare.
  2. Approve or reject all the service items and complete the review.
  3. On the Payment Request page - scroll down and expand the list to see calculations details for crating/uncrating and compare with screenshots to see all the labels are there.

Screenshots

Crating
image
image
image
image

Uncrating
image
image

@taeJungCaci taeJungCaci added ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing labels Feb 6, 2025
@taeJungCaci taeJungCaci self-assigned this Feb 6, 2025
@taeJungCaci taeJungCaci marked this pull request as ready for review February 11, 2025 14:30
@taeJungCaci taeJungCaci requested review from a team as code owners February 11, 2025 14:30
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried my best to break it, tested everything I could. Works for CONUS <-> OCONUS, hits the cap when it needs to. LGTM! Good work - thanks for the nitpicky refactor. Calculations match up, rounding happens when it should!

Screenshot 2025-02-11 at 9 49 30 AM
Screenshot 2025-02-11 at 9 49 30 AM
Screenshot 2025-02-11 at 9 50 15 AM
Screenshot 2025-02-11 at 9 50 15 AM
Screenshot 2025-02-11 at 9 50 45 AM
Screenshot 2025-02-11 at 9 50 45 AM
Screenshot 2025-02-11 at 9 54 23 AM
Screenshot 2025-02-11 at 9 54 23 AM
Screenshot 2025-02-11 at 9 54 51 AM
Screenshot 2025-02-11 at 9 54 51 AM
Screenshot 2025-02-11 at 9 55 14 AM
Screenshot 2025-02-11 at 9 55 14 AM
Screenshot 2025-02-11 at 9 55 24 AM
Screenshot 2025-02-11 at 9 55 24 AM
Screenshot 2025-02-11 at 9 58 57 AM
Screenshot 2025-02-11 at 9 58 57 AM

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also thank you for adding playwright tests!

@taeJungCaci
Copy link
Contributor Author

Also thank you for adding playwright tests!

Thanks for taking the time to review!

Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving

Copy link
Contributor

@KonstanceH KonstanceH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@brooklyn-welsh brooklyn-welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taeJungCaci taeJungCaci merged commit 2fa2a9c into integrationTesting Feb 11, 2025
6 checks passed
@taeJungCaci taeJungCaci deleted the INT-B-21416-intl-crating-TIO-update-for-payment-request branch February 11, 2025 22:48
@taeJungCaci taeJungCaci restored the INT-B-21416-intl-crating-TIO-update-for-payment-request branch February 13, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ByteSize M&Ms Team ByteSized M&Ms INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

5 participants