-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INT B-21416 intl crating tio update for payment request-FE #14766
INT B-21416 intl crating tio update for payment request-FE #14766
Conversation
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
…MAIN-B-21416-intl-crating-TIO-update-for-payment-request
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
…pdate-for-payment-request
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
…pdate-for-payment-request
…pdate-for-payment-request
…t' into INT-B-21416-intl-crating-TIO-update-for-payment-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also thank you for adding playwright tests!
…pdate-for-payment-request
Thanks for taking the time to review! |
…pdate-for-payment-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…pdate-for-payment-request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
B-21416
Summary
This is the FE portion of the implementation done on B-22020.
Displays international crating/uncrating service item payment request param information in TIO payment request review page.
Note: External crating is subject to 4 cubic ft min and all the others are not. Meaning if you select 'External Crate' option when creating the service item, it will charge as 4 cubic ft if the crate size is lower than that.
How to test
NOTE: So currently the crate size - cu ft is allowed 2 decimal places (ex. 0.01) which means it will calculate correctly if the dimensions are at least about 2.6 x 2.6 x 2.6 inches. If you put any lower size than this you will get a cu ft size of 0.00 which will result in $0 for the total amount.
2600
for each L, W, H. Also chooseexternal crate
and 'standalone' option.International crating
service item, but this time don't choose theexternal crate
orstandalone
option and put 2600 or greater for each L, W, H.International uncrating
service item and put at least 2600 for each sizes.If you have selected "External crate" option for International Crating and have chosen dimensions that is less than 4 cu ft, that you should see
Crating size (cu ft) - Minimum 4.00
,Actual size
,External crate
, andMinimum crating size applied
labels.You should also see
OCONUS
label for ICRT if your pickup address isOCONUS
. OtherwiseCONUS
.You should also see
OCONUS
label for IUCRT if your destination address isOCONUS
. OtherwiseCONUS
.Screenshots
Crating




Uncrating

