B-21378: Need to fix RDD Calculation #14782

TevinAdams · 2025-02-10T18:33:10Z

Agility ticket

Summary

Forgot to make RDD based off of scheduledPickupDate + 1 day + UbTransitTime.
This was throwing off the date calculation becaus ei had it as RDD = requiredDeliveryDate + UbTransitTime which is wrong. Obvious mistake.

Required delivery date for a UB shipment is made using the following formula:
rdd = (scheduledPickupDate + 1 day) + re_intl_transit_times.ub_transit_time
Then that rdd value is applied to the UB shipment

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Has the branch been pulled in and checked out?
Have the BL acceptance criteria been met for this change?
Was the CircleCI build successful?
Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

*Note: There may not be a re_intl_transit_times record with a origin_rate_area_id and a destination_rate_area_id that both exists in re_oconus_rate_areas.
In that case you will have to edit an intl_transit_time_record in the DB to have an origin and destination rate area id that does exist in the re_oconus_rate_areas table.

select *
from re_intl_transit_times
where origin_rate_area_id in (select rate_area_id from re_oconus_rate_areas)
and destination_rate_area_id in (select rate_area_id from re_oconus_rate_areas)

Create a UB shipment as a MyMove user

Use addresses that have a us_post_region_cities_id that exist in a record in re_oconus_rate_areas table
Current address I used an address in zipcode 29229
Current duty location: Fort Jackson
Duty Location: Use a duty location that has an address that has a us_post_region_cities_id in re_oconus_rate_areas. In my case I used Eielson, AFB

As SC counsel move
As TOO approve move
As Prime update the shipment with a scheduled pickup date
Check the shipment in the DB and make sure the Required delivery date is populated

Frontend

There are no aXe warnings for UI.
This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
There are no new console errors in the browser devtools.
There are no new console errors in the test output.
If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
This change meets the standards for Section 508 compliance.

Backend

Code follows the guidelines for Logging.
The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

Follows our guidelines for Zero-Downtime Deploys.
Have been communicated to #g-database.
Secure migrations have been tested following the instructions in our docs.

Screenshots

…DD-Transit-Calculation-fix2

danieljordan-caci

Can you update a test to reflect this change?

…DD-Transit-Calculation-fix2

…ation-fix2

cameroncaci

Needs code coverage and is currently double nil checked

pkg/services/mto_shipment/mto_shipment_updater.go

…DD-Transit-Calculation-fix2

TevinAdams · 2025-02-11T13:52:47Z

Needs code coverage and is currently double nil checked

@cameroncaci These lines are covered by a test I wrote to hit these lines in the same package. Screenshot below shows me running the mto_shipment_updater_test.go and is hitting the breakpoints on those lines when executed.

TevinAdams · 2025-02-11T13:53:37Z

Can you update a test to reflect this change?

@danieljordan-caci Test additions added

…ation-fix2

cameroncaci · 2025-02-11T14:29:55Z

@cameroncaci These lines are covered by a test I wrote to hit these lines in the same package. Screenshot below shows me running the mto_shipment_updater_test.go and is hitting the breakpoints on those lines when executed.

Encountered the same, think I might've found the cause. My package test is failing, thus why the code coverage reporter wouldn't cover this. Looks like the package tests are timing out on my machine

danieljordan-caci

Looks like you have failing tests in mto_shipment_updater_test.go

I'd run each suite separately and make those fixes. You also have a nil pointer error failure in TestUpdateRequiredDeliveryDateUpdate

TevinAdams · 2025-02-11T15:30:37Z

Looks like you have failing tests in mto_shipment_updater_test.go

I'd run each suite separately and make those fixes. You also have a nil pointer error failure in TestUpdateRequiredDeliveryDateUpdate

That's weird. These were not failing last PR and these changes did not change anything to make tests fail. Looking now.

…ation-fix2

TevinAdams · 2025-02-13T14:55:46Z

Getting a test error in mto_shipment_updater_test.go:203
"Can only reweigh a shipment that is Approved or Diversion Requested. The shipment's current status is DRAFT"
@danieljordan-caci Yeah thats not form me, and if i am not mistaking that is on int. Nothing i changed would break that.
Looks like you edited lines in that specific test in this PR so I think fixing it would be a good idea. Something merged in between now and then could've messed with it, but I don't feel comfortable approving a PR that has a known failing test in it tbh
@danieljordan-caci Yeah If I had to guess it must have been something similar to what caused the test I made to fail. Looks like something changed with Prime Actual Weight when updating a shipment. But i will look into it.
I'm not sure if I agree with your approach in fixing this issue with the test. I would rather you keep the RDD things in the test instead of remove them per your recent commit

Could you put those values back and fix the underlying issue in the test instead?

Hmm didn't mean to remove that. Im shelving this for a bit so i can focus on some other stuff. Making changes on this im not meaning to make jumping back and forth.

…ation-fix2

…DD-Transit-Calculation-fix2

…ation-fix2

…DD-Transit-Calculation-fix2

…ation-fix2

…DD-Transit-Calculation-fix2

…ation-fix2

TevinAdams · 2025-02-17T22:17:43Z

@cameroncaci @danieljordan-caci Went through all failing tests in pkg mto_shipment and fixed all failing tests. Some were failing for reasons other than code in this PR but they are fixed now.

…ation-fix2

traskowskycaci

I was having the code coverage for pkg/services/mto_shipment timeout so I upped it to 60s with /Users/m.traskowsky_cn/.asdf/shims/go test -timeout 60s -coverprofile=/var/folders/m0/422d8n1951zgm770glhbjst80000gp/T/vscode-goDnb7mg/go-code-cover [github.com/transcom/mymove/pkg/services/mto_shipment](http://github.com/transcom/mymove/pkg/services/mto_shipment)

I see some fails, and I'm not sure if they're due to these changes or not, but mto_shipment_updater_test.go:2619
does have fetchedShipment.RequiredDeliveryDate.Format(time.RFC3339)), as does mto_shipment_updater_test.go:2666 posting the logs here:

--- FAIL: TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus (17.63s)
        --- FAIL: TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments (8.80s)
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2705: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2705
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Received unexpected error:
                                        no international transit time found for destination rate area ID: 3ec11db4-f821-409f-84ad-07fc8e64d60d
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2710: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2710
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Expected value not to be nil.
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            panic.go:262: test panicked: runtime error: invalid memory address or nil pointer dereference

I should also mention the ld_classic errors that clutter up my server test output prevents me from seeing the ok here:

TevinAdams · 2025-02-18T16:58:55Z

I was having the code coverage for pkg/services/mto_shipment timeout so I upped it to 60s with /Users/m.traskowsky_cn/.asdf/shims/go test -timeout 60s -coverprofile=/var/folders/m0/422d8n1951zgm770glhbjst80000gp/T/vscode-goDnb7mg/go-code-cover [github.com/transcom/mymove/pkg/services/mto_shipment](http://github.com/transcom/mymove/pkg/services/mto_shipment)

I see some fails, and I'm not sure if they're due to these changes or not, but mto_shipment_updater_test.go:2619 does have fetchedShipment.RequiredDeliveryDate.Format(time.RFC3339)), as does mto_shipment_updater_test.go:2666 posting the logs here:

--- FAIL: TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus (17.63s)
        --- FAIL: TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments (8.80s)
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2619: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2619
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-07T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-07T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2666: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2666
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Not equal: 
                                        expected: "2018-06-17T00:00:00Z"
                                        actual  : "2018-05-28T00:00:00Z"
                                    
                                        Diff:
                                        --- Expected
                                        +++ Actual
                                        @@ -1 +1 @@
                                        -2018-06-17T00:00:00Z
                                        +2018-05-28T00:00:00Z
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2705: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2705
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Received unexpected error:
                                        no international transit time found for destination rate area ID: 3ec11db4-f821-409f-84ad-07fc8e64d60d
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            mto_shipment_updater_test.go:2710: 
                        Error Trace:    /Users/m.traskowsky_cn/repos/mymove/pkg/services/mto_shipment/mto_shipment_updater_test.go:2710
                                                                /Users/m.traskowsky_cn/.asdf/installs/golang/1.23.1/packages/pkg/mod/github.com/stretchr/[email protected]/suite/suite.go:115
                        Error:          Expected value not to be nil.
                        Test:           TestMTOShipmentServiceSuite/TestUpdateMTOShipmentStatus/Test_that_we_are_properly_adding_days_to_Alaska_shipments
            panic.go:262: test panicked: runtime error: invalid memory address or nil pointer dereference

I should also mention the ld_classic errors that clutter up my server test output prevents me from seeing the ok here:

@traskowskycaci Not understanding this. I fixed all of these. They pass for me locally. Not sure why yours are failing. I just ran the branch locally and these are passing.

traskowskycaci

Verified I did have the latest changes. Talked on slack with Tevin and ran both go test ./pkg/services/mto_shipment and go test ./pkg/services/mto_shipment -cover and those look fine. Still get fails or timeouts when running the vscode coverage tool with 60s, upped from 30s but chalking that up to vscode weirdness.

Using the commands Tevin uses for code coverage, I do see those lines covered:

RDD populated:

…ation-fix2

TevinAdams added 2 commits February 10, 2025 18:26

Merge branch 'RDD Calculation fix

3245755

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

3ba59ed

…DD-Transit-Calculation-fix2

TevinAdams added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Feb 10, 2025

TevinAdams requested review from deandreJones, danieljordan-caci, cameroncaci, traskowskycaci and a team February 10, 2025 18:33

TevinAdams self-assigned this Feb 10, 2025

TevinAdams requested a review from a team as a code owner February 10, 2025 18:33

TevinAdams changed the base branch from main to integrationTesting February 10, 2025 18:33

danieljordan-caci requested changes Feb 10, 2025

View reviewed changes

TevinAdams and others added 3 commits February 10, 2025 22:40

Test addition

2c82f75

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

d436525

…DD-Transit-Calculation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

2d1a80f

…ation-fix2

cameroncaci requested changes Feb 11, 2025

View reviewed changes

pkg/services/mto_shipment/mto_shipment_updater.go Outdated Show resolved Hide resolved

TevinAdams added 2 commits February 11, 2025 13:50

Remove unintended extra nil check

9e87768

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

d288860

…DD-Transit-Calculation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

63b47c8

…ation-fix2

TevinAdams requested review from danieljordan-caci and cameroncaci February 11, 2025 13:54

danieljordan-caci requested changes Feb 11, 2025

View reviewed changes

TevinAdams and others added 3 commits February 11, 2025 10:20

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

43de2aa

…ation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

bdc91d9

…ation-fix2

Test adjustment

eb02184

TevinAdams marked this pull request as draft February 13, 2025 14:52

TevinAdams added 10 commits February 13, 2025 21:19

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

f6b2b27

…ation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

c51b9d0

…ation-fix2

Test fix

b679f5a

Not supposed to do hhg part

14cc64a

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

08d233f

…DD-Transit-Calculation-fix2

Adding back HHG part

1c02aea

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

55b4b96

…DD-Transit-Calculation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

050fc20

…ation-fix2

More test fixes

414208a

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

396fb69

…DD-Transit-Calculation-fix2

TevinAdams marked this pull request as ready for review February 17, 2025 14:05

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

accf177

…ation-fix2

TevinAdams marked this pull request as draft February 17, 2025 14:06

TevinAdams and others added 5 commits February 17, 2025 14:47

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

0f9c9e7

…ation-fix2

A bunch of test fixes

2e6af49

Merge branch 'main' into B-21378-iUB-RDD-Transit-Calculation

458dd61

Merge branch 'B-21378-iUB-RDD-Transit-Calculation' into B-21378-iUB-R…

9f53b37

…DD-Transit-Calculation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

86293d0

…ation-fix2

TevinAdams marked this pull request as ready for review February 17, 2025 22:15

TevinAdams requested review from cameroncaci and danieljordan-caci February 17, 2025 22:16

TevinAdams added 2 commits February 18, 2025 07:39

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

37a021c

…ation-fix2

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

f5484a4

…ation-fix2

traskowskycaci reviewed Feb 18, 2025

View reviewed changes

traskowskycaci approved these changes Feb 18, 2025

View reviewed changes

Merge branch 'integrationTesting' into B-21378-iUB-RDD-Transit-Calcul…

466108e

…ation-fix2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B-21378: Need to fix RDD Calculation #14782

B-21378: Need to fix RDD Calculation #14782

TevinAdams commented Feb 10, 2025

danieljordan-caci left a comment

cameroncaci left a comment

TevinAdams commented Feb 11, 2025

TevinAdams commented Feb 11, 2025

cameroncaci commented Feb 11, 2025

danieljordan-caci left a comment

TevinAdams commented Feb 11, 2025

TevinAdams commented Feb 13, 2025

TevinAdams commented Feb 17, 2025 •

edited

Loading

traskowskycaci left a comment

TevinAdams commented Feb 18, 2025 •

edited

Loading

traskowskycaci left a comment •

edited

Loading

B-21378: Need to fix RDD Calculation #14782

Are you sure you want to change the base?

B-21378: Need to fix RDD Calculation #14782

Conversation

TevinAdams commented Feb 10, 2025

Agility ticket

Summary

Verification Steps for the Author

Verification Steps for Reviewers

Setup to Run the Code

How to test

Frontend

Backend

Database

Any new migrations/schema changes:

Screenshots

danieljordan-caci left a comment

Choose a reason for hiding this comment

cameroncaci left a comment

Choose a reason for hiding this comment

TevinAdams commented Feb 11, 2025

TevinAdams commented Feb 11, 2025

cameroncaci commented Feb 11, 2025

danieljordan-caci left a comment

Choose a reason for hiding this comment

TevinAdams commented Feb 11, 2025

TevinAdams commented Feb 13, 2025

TevinAdams commented Feb 17, 2025 • edited Loading

traskowskycaci left a comment

Choose a reason for hiding this comment

TevinAdams commented Feb 18, 2025 • edited Loading

traskowskycaci left a comment • edited Loading

Choose a reason for hiding this comment

TevinAdams commented Feb 17, 2025 •

edited

Loading

TevinAdams commented Feb 18, 2025 •

edited

Loading

traskowskycaci left a comment •

edited

Loading