B-22307 int deleted expense types

[r-mettler]

B-22307

Summary

This PR addresses an error when attempting to create AOA or payment packets when there are deleted Moving Expenses and/or Pro Gear.

Is there anything you would like reviewers to give additional scrutiny?

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

While testing the below upload and delete some documents along the way to make sure nothing else broke with these changes.

1. Create a new PPM with an Advance as a Customer and submit it
2. Login as a SC and approve the shipment
3. Make sure you can download an AOA packet without errors
4. Login as the Customer and click upload PPM documents
5. Add a Moving Expense and fill out the fields but don't save it, instead click the Return to Homepage button
6. Click Upload PPM Documents
7. Click the delete button for your newly added Moving Expense
8. Add another Moving Expense and fill out and save it
9. Add Pro Gear fill out but don't save, instead click the Return to Homepage button
10. Click Upload PPM Documents
11. Delete the recently added Pro Gear
12. Add another Pro Gear and fill out and save
13. Submit the shipment
14. Login as the SC and click Review Documents and approve the expenses
15. Make sure you can download the Payment Packet without errors
16. Login as the Customer verify you can download the Payment Packet without errors

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[ajlusk]

Agree with Mike's minor suggestion. Other than that I see no issues and testing worked smoothly even when trying to break it with multiple documents and deleting then as both draft and fully saved as well as deleting the whole expense/pro-gear or just the uploaded file.

[MInthavongsay]

Successfully generated PDFs.

[CoryKleinjanCACI]

Looks good. Note Mikes comment.

[r-mettler]

Looks good. Note Mikes comment.

Fixed

[ajlusk]

Still works. Thanks for making the change.