Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 22301 int - Prevent User from Entering Additional Address Until the Preceding Address Is Complete #14825

Merged
merged 17 commits into from
Feb 19, 2025
Merged

B 22301 int - Prevent User from Entering Additional Address Until the Preceding Address Is Complete #14825

merged 17 commits into from
Feb 19, 2025

Conversation

JonSpight
Copy link
Contributor

@JonSpight JonSpight commented Feb 14, 2025 •
edited
Loading

Agility ticket

Previous INT PR

Summary

The application should not allow a customer to enter a new pickup address until the preceding pickup address is entered and valid.

How to test

  1. Turn on FEATURE_FLAG_THIRD_ADDRESS_AVAILABLE
  2. Login as a customer
  3. Add an HHG shipment
  4. Verify the second pickup address toggle options are disabled
  5. Enter a pickup address and verify the second address toggle options are now enabled

How to test PPM

  1. Add a PPM shipment
  2. repeat steps 4-5.
  3. Verify the second destination address toggle options are disabled.
  4. Enter a destination address and verify the second address toggle options are now enabled

How to test NTS

  1. Add a NTS shipment
  2. repeat steps 4-5.

How to test NTS-R

  1. Add a NTS-R shipment
  2. repeat steps 4-5.

How to test Boat

  1. Add a Boat shipment
  2. repeat steps 4-5.

How to test Mobile

  1. Add a Mobile shipment
  2. repeat steps 4-5.

@JonSpight JonSpight self-assigned this Feb 14, 2025
@JonSpight JonSpight added G-Unit Scrum Team G INTEGRATION Slated for Integration Testing frontend labels Feb 17, 2025
@JonSpight JonSpight marked this pull request as ready for review February 17, 2025 14:40
@JonSpight JonSpight requested a review from a team as a code owner February 17, 2025 14:40
@JonSpight JonSpight requested review from a team as code owners February 17, 2025 22:55
@JonSpight JonSpight removed request for a team February 18, 2025 19:59
danieljordan-caci
danieljordan-caci approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@danieljordan-caci danieljordan-caci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - must've missed this on the initial PR cause I requested changes for it haha

@JonSpight JonSpight merged commit 12198ee into integrationTesting Feb 19, 2025
5 of 6 checks passed
@JonSpight JonSpight deleted the B-22301-int branch February 19, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljordan-caci danieljordan-caci danieljordan-caci approved these changes

@pambecker pambecker pambecker approved these changes

@paulstonebraker paulstonebraker Awaiting requested review from paulstonebraker

@loganwc loganwc Awaiting requested review from loganwc

@joeydoyecaci joeydoyecaci Awaiting requested review from joeydoyecaci

Assignees

@JonSpight JonSpight

Labels
frontend G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonSpight @danieljordan-caci @pambecker