Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT-B-22621 Client test fix #14830

Merged
merged 27 commits into from
Feb 17, 2025
Merged

INT-B-22621 Client test fix #14830

merged 27 commits into from
Feb 17, 2025

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Feb 17, 2025

First INT PR

Summary

Had a client test failure due to Daniel's branch having a check on a field that was removed in https://github.com/transcom/mymove/pull/14803/files

Also brings in main changes to int

Client tests passing locally:
image

To test:

  1. Pull branch
  2. Run tests

joeydoyecaci and others added 21 commits February 10, 2025 10:40
…ssage-has-incorrect-URL-for-Technical-Helpdesk

B 22305 main milmove error message has incorrect url for technical helpdesk
…d-Office-Users-List-Sorting

B 21961 add roles to requested office users list sorting
@traskowskycaci traskowskycaci self-assigned this Feb 17, 2025
@traskowskycaci traskowskycaci added Mountain Movers Movin' Mountains 1 Sprint at a time INTEGRATION Slated for Integration Testing labels Feb 17, 2025
@traskowskycaci traskowskycaci changed the title INT-B-22621 Test failures INT-B-22621 Client test fix Feb 17, 2025
@traskowskycaci traskowskycaci marked this pull request as ready for review February 17, 2025 20:33
@traskowskycaci traskowskycaci requested review from a team as code owners February 17, 2025 20:33
deandreJones
deandreJones previously approved these changes Feb 17, 2025
Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing but I'm getting diff ghc.yaml and embedded_spec.go files when running on my local. Could you double check please?

@traskowskycaci
Copy link
Contributor Author

Tests are passing but I'm getting diff ghc.yaml and embedded_spec.go files when running on my local. Could you double check please?

Can you update your local int and try again? Those two files popped up for me as well when I merged in the latest int

Copy link
Contributor

@taeJungCaci taeJungCaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@traskowskycaci traskowskycaci merged commit 879e40f into integrationTesting Feb 17, 2025
6 checks passed
@traskowskycaci traskowskycaci deleted the INT-B-22621 branch February 17, 2025 22:37
@danieljordan-caci
Copy link
Contributor

Thanks for getting this fix in there @traskowskycaci

@danieljordan-caci danieljordan-caci mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Development

Successfully merging this pull request may close these issues.

9 participants