Major version update of cypress to 6.0.0 #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
changed the title
suzubara
requested review from
duncan-truss,
donaldthai,
gidjin and
jenniferlynparsons
lynzt
commented
Dec 7, 2020
| @@ -190,6 +190,7 @@ function serviceMemberAddsWeightTicketSetWithMissingDocuments(hasAnother = false | |||
| cy.get('input[name="full_weight"]').type('5000'); | |||
| cy.upload_file('[data-testid=full-weight-upload] .filepond--root', 'top-secret.png'); | |||
| // cy.wait('@postUploadDocument').its('response.statusCode').should('eq', 201); | |||
There was a problem hiding this comment.
remove the commented out wait and other commented out lines in this file?
and I assume we were failing because there was a timing issue w/ the upload?
There was a problem hiding this comment.
I was leaving these in because we should be able to uncomment them once Cypress fixes the bug (cypress-io/cypress#9359)
| @@ -302,12 +303,12 @@ function serviceMemberSubmitsWeightTicket(vehicleType, hasAnother = true, ordina | |||
| cy.get('input[name="empty_weight"]').type('1000'); | |||
|
|
|||
| cy.upload_file('[data-testid=empty-weight-upload] .filepond--root', 'top-secret.png'); | |||
| cy.wait('@postUploadDocument'); | |||
| // cy.wait('@postUploadDocument').its('response.statusCode').should('eq', 201); | |||
There was a problem hiding this comment.
delete these and other similar comments in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates cypress to
^6.0.0and makes changes according to the Migration Guide:should('not.be.visible')to assert an element that doesn't exist were updated to useshould('not.exist')insteadcy.interceptinstead ofcy.routeand removed the fetch deletion command since window.fetch is now supported/internal/uploadswhich were causing server errors, most likely because of this open bug:cy.intercepton file upload endpoints seems to be reading the file stream, which can result in server-side throwing error cypress-io/cypress#9534Reviewer Notes
If the Cypress tests pass in CI then this PR should be good to go!
Code Review Verification Steps
Querying the Database Safely
have been satisfied.
References