MB-14374 Remove value from ppm_shipment_status enum (NEEDS_CLOSE_OUT)

[Ryan-Koch]

Jira ticket for this change

Summary

This removes the NEEDS_CLOSE_OUT status we added previously for the ppm_shipment_status enum on ppm_shipment. It turned out there were already statuses to handle what we needed.

Approach

For safety reasons it seemed best to go ahead and go about this the following way:

1. Rename the current thing
2. Create a replacement type
3. Make sure we don't have any of the old values in the DB (we shouldn't but just in case)
4. Apply the new type to the status field on the table
5. Drop the old type

Let me know if there's a different way we should go about it.

Verification Steps for Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Request review from a member of a different team.
• Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

Frontend

• User facing changes have been reviewed by design.
• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
• There are no new console errors in the browser devtools
• There are no new console errors in the test output
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.

Backend

• Code follows the guidelines for Logging
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys
• Have been communicated to #g-database
• Secure migrations have been tested following the instructions in our docs

Screenshots

[robot-mymove]

	Messages
📖	🔗 MB-14374

Generated by 🚫 dangerJS against 6ff68c9

[mandaem]

LGTM, ex. I no longer see NEEDS_CLOSE_OUT enum in ppm_shipment_status

[reggieriser]

LGTM! Migration worked fine, and AFAIK, this is the preferred way of removing a value from an enum.