Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changed] Infinite ammo count is shown in singleplayer #2222

Merged

Conversation

mugg91
Copy link
Contributor

@mugg91 mugg91 commented Dec 6, 2024

Status

  • READY

Description

Fixes #2209

In offline singleplayer, when using a mounted bow or a catapult, you get to have infinite ammo.
But there is no ammo count drawn to indicate this.
This PR makes changes to VehicleGUI.as to show an infinite symbol.

I made some other changes to simplify the code a bit in drawAmmoCount() but let me know if it is good or not.

Before After
Bow in Save The Princess BowBefore BowAfter
Catapult in other gamemodes CatapultBefore CatapultAfter

Copy link
Member

@Vam-Jam Vam-Jam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vam-Jam Vam-Jam added no functional change PRs with no gameplay change or visible bug solved; generally tagged for refactor PRs ready A pull request that functions correctly and is ready for testing labels Dec 9, 2024
@Vam-Jam Vam-Jam added this to the Next Patch milestone Dec 9, 2024
@asumagic asumagic merged commit 78a66f2 into transhumandesign:master Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no functional change PRs with no gameplay change or visible bug solved; generally tagged for refactor PRs ready A pull request that functions correctly and is ready for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vehicle ammo count is not shown in offline
3 participants