[changed] Mounted Bow can be detached from other vehicles #2267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vam-Jam
requested changes
Jan 18, 2025
| @@ -25,10 +25,12 @@ void GetButtonsFor(CBlob@ this, CBlob@ caller) | |||
| CBlob@ occBlob = ap.getOccupied(); | |||
| if (occBlob !is null) //detach button | |||
| { | |||
| if (this.isOnGround() && occBlob.getName() != "mounted_bow") // HACK: | |||
| if (this.isOnGround() || occBlob.getName() == "mounted_bow") // HACK: | |||
There was a problem hiding this comment.
Pr works fine, but IMO just remove the getName check, does not make sense to have the bow as the only thing you can drop while flying/moving.
| @@ -60,7 +62,7 @@ void onCommand(CBlob@ this, u8 cmd, CBitStream @params) | |||
| // range check | |||
| if (this.getDistanceTo(b) > 64.0f) return; | |||
|
|
|||
| if (this.isOnGround() && occBlob.getName() != "mounted_bow") | |||
| if (this.isOnGround() || occBlob.getName() == "mounted_bow") | |||
Vam-Jam
added
change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
Fixes #2207
You are allowed to detach mounted bow that is attached to other vehicles (longboat, warboat, airship, bomber).
The button offset was misplaced for longboat and bomber and I fixed it by dividing the
ap.offsetby 2.The mounted bow on warboat still cannot be detached after this change.
Tested in offline.