Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

companion: return mimetypes for dropbox files #1599

Merged
merged 1 commit into from
May 31, 2019
Merged

companion: return mimetypes for dropbox files #1599

merged 1 commit into from
May 31, 2019

Conversation

ifedapoolarewaju
Copy link
Contributor

fixes #869

@ifedapoolarewaju ifedapoolarewaju force-pushed the dropbox-custom-mimetype branch from 44c92ba to 638d147 Compare May 26, 2019 15:28
goto-bus-stop
goto-bus-stop approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@arturi
Copy link
Contributor

arturi commented May 27, 2019

Very nice! Code looks good, will test it once and then approve.

@arturi
Copy link
Contributor

arturi commented May 27, 2019

Would it make sense to refactor this to some general method/component, so that it can later be used in other plugins? So then you check like if (!type) detectType()?

@ifedapoolarewaju
Copy link
Contributor Author

Would it make sense to refactor this to some general method/component, so that it can later be used in other plugins? So then you check like if (!type) detectType()?

I don't think we need to do that now. When the need truly arises, we can proceed to refactor it.

arturi
arturi approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@arturi arturi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the need truly arises, we can proceed to refactor it.

👌

Tested, works! Thanks.

@arturi arturi merged commit 1ffbf14 into master May 31, 2019
@arturi arturi deleted the dropbox-custom-mimetype branch May 31, 2019 15:36
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@ifedapoolarewaju @arturi
companion: return mimetypes for dropbox files (transloadit#1599)
4fd3f6e 
fixes transloadit#869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

@arturi arturi arturi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File type restriction does not work for dropbox files
3 participants
@ifedapoolarewaju @arturi @goto-bus-stop