Refactor/dedupe cookie/session logic #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that we also send sameSite for session cookies this might fix the issue where sessions are recreated for every single request
aduh95
approved these changes
Apr 24, 2023
Co-authored-by: Antoine du Hamel <[email protected]>
mifi
added a commit
that referenced
this pull request
Apr 24, 2023
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
* refactor/dedupe cookie logic so that we also send sameSite for session cookies this might fix the issue where sessions are recreated for every single request * "fix" test * Apply suggestions from code review Co-authored-by: Antoine du Hamel <[email protected]> --------- Co-authored-by: Antoine du Hamel <[email protected]>
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
Revert "Refactor/dedupe cookie/session logic (transloadit#4420)" This reverts commit 354cc30.
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we also send sameSite for session cookies
this might fix the issue where sessions are recreated for every single request
note: this is hard to test in dev because it needs a https proxy in front
related #4394