Integrate operates in terms of hashes #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
integrate_hashes
branch
from
4e32b06 to
3d768c8
Compare
AlCutter
force-pushed
the
integrate_hashes
branch
from
3d768c8 to
0675db5
Compare
AlCutter
force-pushed
the
integrate_hashes
branch
from
0675db5 to
c855260
Compare
phbnf
approved these changes
Jan 9, 2025
|
I wanted to leave a comment on this saying congrats on making integrate more performant: https://transparency-dev.github.io/trillian-tessera/dev/bench/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the integration helper to only require knowledge of leaf hashes, it should not need to know anything else about the leaves.
This minor change helps with modularity, and opens the door to using the helper in other log lifecycle modes (e.g. migration #436 ).