Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerations support #11

Merged
merged 5 commits into from
Jul 9, 2019
Merged

Add tolerations support #11

merged 5 commits into from
Jul 9, 2019

Conversation

FlavioF
Copy link
Contributor

@FlavioF FlavioF commented Jul 4, 2019

Motivation
At the moment it is not possible to setup tolerations for Aerospike pods. Aerospike is a stateful application with special storage, memory and cpu needs. Mainly for that reason we would like to be able to allow it to go to special nodes in the k8s cluster.

Proposal
Allow user to define tolerations.

Example

----
apiVersion: aerospike.travelaudience.com/v1alpha2
kind: AerospikeCluster
metadata:
  name: example-aerospike-cluster
  namespace: example-namespace
spec:
  version: "4.2.0.3"
  nodeCount: 3
  tolerations:
  - key: "aerospike"
    operator: "Exists"
    effect: "NoSchedule"
  backupSpec:
      storage:
        type: gcs
        bucket: test-bucket
        secret: bucket-secret
  namespaces:
  - name: as-namespace-0
    replicationFactor: 2
    memorySize: 4G
    defaultTTL: 0s
    storage:
      type: file
      size: 150G
----

@FlavioF FlavioF added the enhancement New feature or request label Jul 4, 2019
@FlavioF FlavioF self-assigned this Jul 4, 2019
@pires
Copy link
Contributor

pires commented Jul 4, 2019

Can you address feedback in #10 before I review this PR?

pires
pires suggested changes Jul 9, 2019
View reviewed changes
docs/usage/10-managing-clusters.adoc Outdated Show resolved Hide resolved
pires
pires previously requested changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@pires pires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the world of conflicts. Please, resolve :D

@FlavioF FlavioF force-pushed the add_tolerations_support branch from f485d9c to 5986710 Compare July 9, 2019 11:00
@FlavioF FlavioF requested a review from pires July 9, 2019 11:01
@FlavioF FlavioF dismissed pires’s stale review July 9, 2019 11:01

Conflicts fixed

@pires pires merged commit 34f9766 into master Jul 9, 2019
@pires pires deleted the add_tolerations_support branch July 9, 2019 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pires pires pires approved these changes

Assignees

@FlavioF FlavioF

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlavioF @pires