Properly handle pods in Error state after initialisation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pires <[email protected]>
|
I think the logic in |
pires
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Before we were handling pod related checks and cluster related checks in the same loop. My proposal is separate that in order to fix #12.
Explanation
It looks that for each pod AS operator is validating cluster size both in k8s and in Aerospike. For the scenario described in #12 the validation is failing. This fail happens for AS pod with index 1 in first place, so the operator decides to kill that pod to try to fix cluster size problem. However, since it is happening because one of the other AS pods is in Error state, AS operator start the erroneous loop described in #12.
The idea around this PR is to separate AS pod checks from AS cluster checks. So, every pod is checked first. After that the state of the AS cluster for every AS pod is checked.