Refactor cli #54
Merged
Refactor cli #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| brokerID = kingpin.Flag("id", "Broker ID").Int32() | ||
| debugLogs = kingpin.Flag("debug", "Enable debug logs").Default("false").Bool() | ||
| cli = kingpin.New("jocko", "Jocko, a Go implementation of Kafka") | ||
| logDir = cli.Flag("logdir", "A comma separated list of directories under which to store log files").Default("/tmp/jocko").String() |
There was a problem hiding this comment.
we can mv logDir into the brokerCmd
|
I like it. Hashicorp uses a similar command/UI with their stuff like Consul. There's some minor fixes I'll make but I'll merge and fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to work on some CLI commands mentioned in #16 and felt I first needed to refactor the CLI to have different commands:
brokercommand so create broker is now executed withjocko broker ...jocko topic ...This can now be easily extended with new commands such as
jocko topic list,jocko topic create --name=topic1orjocko consumer --topic=topic1.