Added Prometheus client and exposed number of requests handled #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm not sure why the build is failing. I've added the prometheus dependencies to vendor.json, however |
|
Awesome! Merged it: 5aa4d9b. Keep the contributions coming. If you haven't joined the Slack (or Gitter) yet please do! |
travisjeffery
pushed a commit
that referenced
this pull request
Oct 10, 2017
|
@travisjeffery @BasPH instead of using prometheus client directly would it make sense to use abstraction like OpenCensus (see https://github.com/census-instrumentation/opencensus-go and http://opencensus.io/) ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added Prometheus instrumentation (#16). Currently it exposes the default
go_*metrics and one additionalrequests_handledmetric.By default it exposes metrics on localhost:9095/metrics, however this is parameterised.