Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 to CI #370

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Add Ruby 3.1 to CI #370

merged 1 commit into from
Jan 14, 2022

Conversation

petergoldstein
Copy link
Contributor

As Ruby 3.1 is released, it should be added to CI as a formal entry.

@ramonskie ramonskie mentioned this pull request Jan 14, 2022
@joshuacronemeyer joshuacronemeyer merged commit 9520d05 into travisjeffery:master Jan 14, 2022
@joshuacronemeyer
Copy link
Collaborator

thanks @petergoldstein. Merging this and merged a couple other PRs along with it to hopefully get back to a green build. Looks like the failures were from ruby >=3.1 removing some stuff from the standard lib that older nokogiris required. Updating nokogiri solved those failures.

@petergoldstein
Copy link
Contributor Author

@joshuacronemeyer Great. I actually was planning on getting this running myself, but I'm glad you got it done.

@joshuacronemeyer
Copy link
Collaborator

I couldn't get our build passing for ruby 2.5. If you feel like it you could take a look at those build failures. Since ruby 2.5 support ended in 3/2021 I went ahead and removed it in favor of getting a passing build.

@petergoldstein
Copy link
Contributor Author

I think removing Ruby 2.5 is the right move. It's EOL and Ruby 2.6 is EOLing in ~2 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants