SocketManager: Enable open(nil) to select path automatically

[daipom]

• Fixes Windows: Apply excluded port range to SocketManager #140.

I already created

• Consider excluded port ranges for Windows #142

but we need a more fundamental solution as discussed in #140.

This PR enables ServerEngine::SocketManager::Server.open(nil) to select path automatically.

Especially on Windows, it is hard to search an available port for path, so we should use this feature.
(The current generate_path logic sometimes chooses an unavailable port. For example, it does not consider the excluded port range.)

This fix keeps backward compatibility.

[daipom]

Though quite late now, I'm starting to think this may be better...

serverengine/lib/serverengine/socket_manager.rb

Lines 91 to 93 in 6c23c4a

	def self.open(path)
	new(path)
	end

def self.open(path = nil)
  return new(path) unless path.nil?
  if ServerEngine.windows?
    new(0)
  else
    new(self.generate_path)
  end
end

[daipom]

Though quite late now, I'm starting to think this may be better...

serverengine/lib/serverengine/socket_manager.rb

Lines 91 to 93 in 6c23c4a

	def self.open(path)
	new(path)
	end

def self.open(path = nil)
  return new(path) unless path.nil?
  if ServerEngine.windows?
    new(0)
  else
    new(self.generate_path)
  end
end

What do you think? If so, I will fix.

[ashie]

LGTM

[ashie]

Thanks!

[daipom]

Thanks for your review!