Add base64 and logger gem as dependency for Ruby 3.4 and 3.5 #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watson1978
changed the title
The `base64` gem was marked as bundled gem for Ruby 3.4. Ref. ruby/ruby@6500f85 And, the `logger` gem was marked as bundled gem for Ruby 3.5. Ref. ruby/ruby@d7e558e This patch will suppress the following warning message: ``` socket_manager.rb:23: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. config_loader.rb:18: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. ``` Signed-off-by: Shizuo Fujita <[email protected]>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
base64gem was marked as bundled gem for Ruby 3.4.Ref. ruby/ruby@6500f85
And, the
loggergem was marked as bundled gem for Ruby 3.5.Ref. ruby/ruby@d7e558e
This patch will suppress the following warning message: