Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanner: do not skip LINE_BREAKs before .. and ... #238

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Scanner: do not skip LINE_BREAKs before .. and ... #238

merged 1 commit into from
Jun 7, 2023

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Jun 7, 2023 •
edited
Loading

Checklist:

  • All tests pass in CI.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

See also: #237

hendrikvanantwerpen
hendrikvanantwerpen approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@hendrikvanantwerpen hendrikvanantwerpen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and thanks as always for including clear test cases!

@aibaars aibaars merged commit 74fde5e into tree-sitter:master Jun 7, 2023
This was referenced Jun 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikvanantwerpen hendrikvanantwerpen hendrikvanantwerpen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aibaars @hendrikvanantwerpen