Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic and static text examples. #29

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Add dynamic and static text examples. #29

merged 4 commits into from
Mar 22, 2022

Conversation

treeform
Copy link
Owner

No description provided.

@creikey
Copy link

creikey commented Mar 21, 2022

https://github.com/treeform/boxy/pull/29/files#diff-a6e76ad1045d68a2ac2faf0d9a5949a0ac72d9d494d4880cd99921cf42283310R25
Compute bounds returns a vec2 but snapToPixels takes a rect right?

@guzba
Copy link
Collaborator

guzba commented Mar 21, 2022

@creikey We're revisiting how text's computeBounds works to address some shortcomings with the previous approach. This PR is a bit ahead of what is finalized and merged into Pixie.

@treeform treeform merged commit 04d28e7 into master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants