Add nodePort to helm service.yaml #282
Conversation
|
|
charts/lakefs/templates/service.yaml
Outdated
| @@ -9,6 +9,9 @@ spec: | |||
| ports: | |||
| - port: {{ .Values.service.port }} | |||
| targetPort: http | |||
| {{- if .Values.service.nodePort }} | |||
There was a problem hiding this comment.
please keep the if statement at the same ident level as the field itself
There was a problem hiding this comment.
Updated indentation
charts/lakefs/templates/service.yaml
Outdated
| @@ -9,6 +9,9 @@ spec: | |||
| ports: | |||
| - port: {{ .Values.service.port }} | |||
| targetPort: http | |||
| {{- if .Values.service.nodePort }} | |||
There was a problem hiding this comment.
please assert that .Values.service.type == "NodePort" to avoid issues for users configuring this.
There was a problem hiding this comment.
Added check for .Values.service.type
|
@Isan-Rivkin Your requested changes have been made. Awaiting your conversation resolutions. |
|
@gauthier-labs thanks for the update! Looks good! |
Update version
spacing
|
@Isan-Rivkin Version has been updated. |
There was a problem hiding this comment.
LGTM @gauthier-labs !
Thank you for the patience and contribution!
Adding nodePort to the service.yaml enables a static external port to access the LakeFS GUI.
This is good for smaller deployments and testing.