Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: StatsObject non nil on empty metadata #7026

Merged
merged 2 commits into from
Nov 22, 2023
Merged

API: StatsObject non nil on empty metadata #7026

merged 2 commits into from
Nov 22, 2023

Conversation

nopcoder
Copy link
Contributor

Align response with upload response

Close #7013

@nopcoder
API: stats return non nil metadata
697ff62 
align response with upload
@nopcoder nopcoder added bug Something isn't working area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog labels Nov 21, 2023
@nopcoder nopcoder requested a review from N-o-Z November 21, 2023 20:49
@nopcoder nopcoder self-assigned this Nov 21, 2023
N-o-Z
N-o-Z approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

pkg/api/controller.go
@@ -2766,6 +2766,7 @@ func (c *Controller) UploadObject(w http.ResponseWriter, r *http.Request, reposi
PhysicalAddress: qk.Format(),
SizeBytes: swag.Int64(blob.Size),
ContentType: &contentType,
Metadata: &apigen.ObjectUserMetadata{AdditionalProperties: meta},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

pkg/api/controller.go
@@ -2898,6 +2899,13 @@ func (c *Controller) CopyObject(w http.ResponseWriter, r *http.Request, body api
return
}

var metadata map[string]string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even nicer 😃

@nopcoder nopcoder merged commit bbea569 into master Nov 22, 2023
30 checks passed
@nopcoder nopcoder deleted the fix/stat-metadata branch November 22, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees

@nopcoder nopcoder

Labels
area/API Improvements or additions to the API bug Something isn't working include-changelog PR description should be included in next release changelog
Projects
None yet
Milestone
No milestone
2 participants
@nopcoder @N-o-Z