Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Importing a single object for local blockstore #7069

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

Isan-Rivkin
Copy link
Contributor

@Isan-Rivkin Isan-Rivkin commented Nov 27, 2023

Closes #6913

lakeFS supports that requirement in here, must use HTTP API or our API clients, so updated the documentation.

Example usage:

curl 'http://localhost:8000/api/v1/repositories/repo/branches/main/import' \
  -u '<LAKEFS_USER>:<LAKEFS_SECRET>' \
  --data-raw '{"paths":[{"path":"local:///tmp/data/file1.yaml","destination":"imports/file1.yaml","type":"object"}],"commit":{"message":""}}' \
  --compressed | jq .

@Isan-Rivkin Isan-Rivkin self-assigned this Nov 27, 2023
@Isan-Rivkin Isan-Rivkin added the exclude-changelog PR description should not be included in next release changelog label Nov 27, 2023
Copy link

github-actions bot commented Nov 27, 2023

♻️ PR Preview 792e521 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@kesarwam
Copy link
Contributor

kesarwam commented Nov 27, 2023

@Isan-Rivkin This section in the documentation should also be changed: https://docs.lakefs.io/howto/deploy/onprem.html#limitations

@kesarwam
Copy link
Contributor

kesarwam commented Nov 27, 2023

@Isan-Rivkin Can you also document what should be the "destination" for single object import e.g. destination="json/file.json"

An example in the documentation like above will be helpful:

curl 'http://localhost:8000/api/v1/repositories/repo/branches/main/import' \
  -u '<LAKEFS_USER>:<LAKEFS_SECRET>' \
  --data-raw '{"paths":[{"path":"local:///tmp/data/file1.yaml","destination":"imports//file1.yaml","type":"object"}],"commit":{"message":""}}' \
  --compressed | jq .

@Isan-Rivkin
Copy link
Contributor Author

Thanks @kesarwam updated!

@Isan-Rivkin Isan-Rivkin enabled auto-merge (squash) November 28, 2023 08:35
@Isan-Rivkin
Copy link
Contributor Author

Thanks @johnnyaug !

@Isan-Rivkin Isan-Rivkin merged commit 9bd29a8 into master Nov 28, 2023
@Isan-Rivkin Isan-Rivkin deleted the 6913-import-single-obj-local branch November 28, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import a single object for local blockstore
3 participants