Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @lakeFS Mastodon account #8466

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Remove @lakeFS Mastodon account #8466

merged 2 commits into from
Jan 5, 2025

Conversation

arielshaqed
Copy link
Contributor

It's unused, to the extent that the server itself is now down. So the link itself is broken.

@arielshaqed
Remove @lakeFS Mastodon account
7ca957e 
It's unused, to the extent that the _server itself_ is now down.  So the link itself is broken.
@arielshaqed arielshaqed added bug Something isn't working docs Improvements or additions to documentation minor-change Used for PRs that don't require issue attached pr/merge-if-approved Reviewer: please feel free to merge if no major comments exclude-changelog PR description should not be included in next release changelog labels Jan 5, 2025
@arielshaqed
Copy link
Contributor Author

E.g. this failure because the link is broken.

@arielshaqed arielshaqed marked this pull request as draft January 5, 2025 21:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

@arielshaqed
Copy link
Contributor Author

(Moved to draft because this is hardly enough, there are several more broken pieces)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

E2E Test Results - Quickstart

11 passed

@arielshaqed
Remove all other Mastodon links
59efad1 
Also the Mastodon graphics assets, they appear unused.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025 •
edited
Loading

♻️ PR Preview 59efad1 has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@arielshaqed arielshaqed marked this pull request as ready for review January 5, 2025 21:30
@arielshaqed
Copy link
Contributor Author

Links checker now happy - so ready for review I guess.

@ozkatz ozkatz merged commit a447d7a into master Jan 5, 2025
39 checks passed
@ozkatz ozkatz deleted the chore/remove-dead-mastodon-account branch January 5, 2025 21:51
@arielshaqed
Copy link
Contributor Author

Thanks! Hoping for a greener ci, and being able to detect future broken links..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkatz ozkatz ozkatz approved these changes

@keren-lakeFS keren-lakeFS Awaiting requested review from keren-lakeFS

Assignees
No one assigned
Labels
bug Something isn't working docs Improvements or additions to documentation exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached pr/merge-if-approved Reviewer: please feel free to merge if no major comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielshaqed @ozkatz