8422 list multipart uploads

esti/s3_gateway_test.go

@@ -347,6 +347,23 @@ func TestListMultipartUploads(t *testing.T) {
 	require.Contains(t, keys, obj1)
 	require.Contains(t, keys, obj2)
 
+	// testing maxuploads - only first upload should return
+	maxUploads := aws.Int32(1)
+	output, err = s3Client.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{Bucket: resp1.Bucket, MaxUploads: maxUploads})
+	require.NoError(t, err, "failed to list multipart uploads")
+	keys = extractUploadKeys(output)
+	require.Contains(t, keys, obj1)
+	require.NotContains(t, keys, obj2)
+
+	// testing key marker and upload id marker for pagination. only records after marker should return
+	keyMarker := output.NextKeyMarker
+	uploadIDMarker := output.NextUploadIdMarker
+	output, err = s3Client.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{Bucket: resp1.Bucket, MaxUploads: maxUploads, KeyMarker: keyMarker, UploadIdMarker: uploadIDMarker})
+	require.NoError(t, err, "failed to list multipart uploads")
+	keys = extractUploadKeys(output)
+	require.NotContains(t, keys, obj1)
+	require.Contains(t, keys, obj2)
+
 	// finish first mpu check only second appear
 	_, err = s3Client.CompleteMultipartUpload(ctx, completeInput1)
 	require.NoError(t, err, "failed to complete multipart upload")
@@ -355,6 +372,23 @@ func TestListMultipartUploads(t *testing.T) {
 	keys = extractUploadKeys(output)
 	require.NotContains(t, keys, obj1)
 	require.Contains(t, keys, obj2)
+
+	// unsupported headers, expect error
+	delimiter := aws.String("/")
+	prefix := aws.String("prefix")
+	encodingType := types.EncodingTypeUrl
+
+	output, err = s3Client.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{Bucket: resp1.Bucket, Delimiter: delimiter})
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "NotImplemented")
+
+	output, err = s3Client.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{Bucket: resp1.Bucket, Prefix: prefix})
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "NotImplemented")
+
+	output, err = s3Client.ListMultipartUploads(ctx, &s3.ListMultipartUploadsInput{Bucket: resp1.Bucket, EncodingType: encodingType})
+	require.Error(t, err)
+	require.Contains(t, err.Error(), "NotImplemented")
 }
 
 func extractUploadKeys(output *s3.ListMultipartUploadsOutput) []string {

pkg/block/adapter.go

@@ -127,6 +127,7 @@ type ListMultipartUploadsResponse struct {
 	Uploads            []types.MultipartUpload
 	NextUploadIDMarker *string
 	NextKeyMarker      *string
+	IsTruncated        bool
 }
 
 // CreateMultiPartUploadOpts contains optional arguments for

pkg/block/s3/adapter.go

@@ -881,6 +881,7 @@ func (a *Adapter) ListMultipartUploads(ctx context.Context, obj block.ObjectPoin
 		Uploads:            resp.Uploads,
 		NextUploadIDMarker: resp.NextUploadIdMarker,
 		NextKeyMarker:      resp.NextKeyMarker,
+		IsTruncated:        *resp.IsTruncated,
 	}
 	return &mpuResp, nil
 }

pkg/gateway/operations/listobjects.go

@@ -26,6 +26,10 @@ const (
 	QueryParamMaxUploads     = "max-uploads"
 	QueryParamUploadIDMarker = "upload-id-marker"
 	QueryParamKeyMarker      = "key-marker"
+	// missing implementation - will return error
+	QueryParampPrefix       = "prefix"
+	QueryParampEncodingType = "encoding-type"
+	QueryParampDelimiter    = "delimiter"
 )
 
 type ListObjects struct{}
@@ -409,6 +413,13 @@ func handleListMultipartUploads(w http.ResponseWriter, req *http.Request, o *Rep
 	maxUploadsStr := query.Get(QueryParamMaxUploads)
 	uploadIDMarker := query.Get(QueryParamUploadIDMarker)
 	keyMarker := query.Get(QueryParamKeyMarker)
+	prefix := query.Get(QueryParampPrefix)
+	delimiter := query.Get(QueryParampDelimiter)
+	encodingType := query.Get(QueryParampEncodingType)
+	if prefix != "" || delimiter != "" || encodingType != "" {
+		_ = o.EncodeError(w, req, gatewayerrors.ErrNotImplemented, gatewayerrors.Codes.ToAPIErr(gatewayerrors.ErrNotImplemented))
+		return
+	}
 	opts := block.ListMultipartUploadsOpts{}
 	if maxUploadsStr != "" {
 		maxUploads, err := strconv.ParseInt(maxUploadsStr, 10, 32)
@@ -462,6 +473,7 @@ func handleListMultipartUploads(w http.ResponseWriter, req *http.Request, o *Rep
 		Uploads:            uploads,
 		NextKeyMarker:      *mpuResp.NextKeyMarker,
 		NextUploadIDMarker: *mpuResp.NextUploadIDMarker,
+		IsTruncated:        mpuResp.IsTruncated,
 	}
 	o.EncodeResponse(w, req, resp, http.StatusOK)
 }

pkg/gateway/serde/xml.go

@@ -170,6 +170,7 @@ type ListMultipartUploadsOutput struct {
 	Uploads            []Upload `xml:"Upload"`
 	NextKeyMarker      string   `xml:"NextKeyMarker"`
 	NextUploadIDMarker string   `xml:"NextUploadIDMarker"`
+	IsTruncated        bool     `xml:"IsTruncated"`
 }
 
 type VersioningConfiguration struct {