Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webui lock file update for react-dropzone 14.2.3 #8544

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

nopcoder
Copy link
Contributor

Sync web UI package lock file.

@nopcoder nopcoder added the minor-change Used for PRs that don't require issue attached label Jan 24, 2025
@nopcoder nopcoder self-assigned this Jan 24, 2025
Copy link

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link

E2E Test Results - Quickstart

11 passed

@nopcoder nopcoder added the exclude-changelog PR description should not be included in next release changelog label Jan 24, 2025
@nopcoder nopcoder requested review from N-o-Z and itaigilo January 26, 2025 07:26
@itaigilo
Copy link
Contributor

@nopcoder What should this change solve?

@nopcoder
Copy link
Contributor Author

@nopcoder What should this change solve?

It should sync the change that was made in package.json into the lock file.
Currently if you run npm install on your env you will see that npm will update your package lock to reflect that. This change commits this modification.

@itaigilo
Copy link
Contributor

@nopcoder What should this change solve?

It should sync the change that was made in package.json into the lock file. Currently if you run npm install on your env you will see that npm will update your package lock to reflect that. This change commits this modification.

So why react-dropzone should not get a caret, while all other packages get it?

(In my opinion, we should either decide that we're locking the versions for all our packages, or we should be ok with updating the package.lock from time to time.)

@nopcoder
Copy link
Contributor Author

@itaigilo a bug in the newer version was found by @N-o-Z and he locked the specific version in package.json. This change reflects the change to the lock file.

I assume we should return to use ^ as soon as the issue will be resolved with the package.

Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Regarding the comment, I don't think there's going to be a fix in later versions. I think this was a change of behavior that broke our usage

@nopcoder nopcoder merged commit 7e93e63 into master Jan 26, 2025
41 of 43 checks passed
@nopcoder nopcoder deleted the fix/package-lock branch January 26, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants