Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fs:CreateMetaRange permission #8552

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Remove fs:CreateMetaRange permission #8552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion contrib/auth/acl/service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,6 @@ func TestACL(t *testing.T) {
{Action: permissions.DeleteObjectAction, Resource: permissions.ObjectArn("foo", "some/path")},
{Action: permissions.CreateBranchAction, Resource: permissions.BranchArn("foo", "twig")},
{Action: permissions.CreateCommitAction, Resource: permissions.BranchArn("foo", "twig")},
{Action: permissions.CreateMetaRangeAction, Resource: permissions.RepoArn("foo")},
},
authacl.SuperPermission: []permissions.Permission{
{Action: permissions.AttachStorageNamespaceAction, Resource: permissions.StorageNamespace("storage://bucket/path")},
Expand Down
2 changes: 1 addition & 1 deletion docs/howto/import.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ lakeFS Enterprise
{: .label .label-purple }

With RBAC support, The lakeFS user running the import command should have the following permissions in lakeFS:
`fs:WriteObject`, `fs:CreateMetaRange`, `fs:CreateCommit`, `fs:ImportFromStorage` and `fs:ImportCancel`.
`fs:WriteObject`, `fs:CreateCommit`, `fs:ImportFromStorage` and `fs:ImportCancel`.

As mentioned above, all of these permissions are available by default to the Supers (open-source) group or the SuperUsers (Cloud/Enterprise).

Expand Down
2 changes: 0 additions & 2 deletions docs/howto/mirroring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ The user should have the following [RBAC policy](../security/rbac.html) attached
"fs:DeleteObject",
"fs:ListObjects",
"fs:CreateCommit",
"fs:CreateMetaRange",
"fs:ReadCommit",
"fs:ListCommits",
"fs:CreateBranch",
Expand Down Expand Up @@ -149,7 +148,6 @@ The user should have the following [RBAC policy](../security/rbac.html) attached
"fs:DeleteObject",
"fs:ListObjects",
"fs:CreateCommit",
"fs:CreateMetaRange",
"fs:ReadCommit",
"fs:ListCommits",
"fs:CreateBranch",
Expand Down
3 changes: 1 addition & 2 deletions docs/security/rbac.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,7 @@ The following Policies are created during initial setup:
"fs:CreateTag",
"fs:DeleteBranch",
"fs:DeleteTag",
"fs:CreateCommit",
"fs:CreateMetaRange"
"fs:CreateCommit"
],
"effect": "allow",
"resource": "*"
Expand Down
1 change: 0 additions & 1 deletion pkg/auth/base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ var statementByName = map[string]model.Statement{
permissions.DeleteBranchAction,
permissions.DeleteTagAction,
permissions.CreateCommitAction,
permissions.CreateMetaRangeAction,
},
Effect: model.StatementEffectAllow,
},
Expand Down
1 change: 0 additions & 1 deletion pkg/permissions/actions.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pkg/permissions/actions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const (
DeleteObjectAction = "fs:DeleteObject"
ListObjectsAction = "fs:ListObjects"
CreateCommitAction = "fs:CreateCommit"
CreateMetaRangeAction = "fs:CreateMetaRange"
ReadCommitAction = "fs:ReadCommit"
ListCommitsAction = "fs:ListCommits"
CreateBranchAction = "fs:CreateBranch"
Expand Down
Loading