Extract Esti utils #8713
Merged
Extract Esti utils #8713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-o-Z
added
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
| @@ -11,10 +11,13 @@ import ( | |||
| "net/url" | |||
| "path/filepath" | |||
| "regexp" | |||
| "slices" | |||
There was a problem hiding this comment.
I'm not crazy about files called "utils". They tend to become dumping grounds for all sorts of loosely related code. I think that all the "cleanup" code could be in a file called "esti_cleanup" or something like that
There was a problem hiding this comment.
We can refactor the files later, creating a lot of very small code files is also something that is objectionable
N-o-Z
force-pushed
the
task/extract-esti-utils
branch
from
81e9b6b to
89b65a8
Compare
N-o-Z
force-pushed
the
task/extract-esti-utils
branch
from
49bc648 to
153e885
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Esti logic to provide more reusable functionality