Skip to content

Commit

Permalink
fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Jeff Carter committed Nov 3, 2020
1 parent 8c10f60 commit 93bc3fd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lister/firehose_firehose.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func (l AWSFirehoseStream) List(cfg option.AWSetsConfig) (*resource.Group, error
return nil, fmt.Errorf("failed to describe delivery stream %s: %w", *ds, err)
}
if *describeRes.DeliveryStreamDescription.HasMoreDestinations {
cfg.SendStatus(option.StatusLogError, fmt.Sprintf("need to page through destinations for %s", ds))
cfg.SendStatus(option.StatusLogError, fmt.Sprintf("need to page through destinations for %s", *ds))
}
dsArn := arn.ParseP(describeRes.DeliveryStreamDescription.DeliveryStreamARN)
r := resource.New(cfg, resource.FirehoseDeliveryStream, dsArn.ResourceId, describeRes.DeliveryStreamDescription.DeliveryStreamName, describeRes.DeliveryStreamDescription)
Expand Down
7 changes: 3 additions & 4 deletions resource/resource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ func getConfig() option.AWSetsConfig {
AWSCfg: config,
AccountId: "123456789",
Context: context.Background(),
Logger: option.NoOpLogger{},
}
}

Expand Down Expand Up @@ -161,17 +160,17 @@ func Test_JSON(t *testing.T) {
rg := NewGroup()

cfgUsEast1 := getConfig()
cfgUsEast2 := cfgUsEast1.Copy("us-east-2")
cfgUsEast2 := cfgUsEast1.CopyWithRegion("us-east-2")
object := map[string]interface{}{
"Foo": "Bar",
"Tags": map[string]string{
"tag1": "value1",
"tag2": "value2",
},
}
r1 := New(cfgUsEast2, Ec2Instance, "resource 1", "resource_1", object)
r1 := New(*cfgUsEast2, Ec2Instance, "resource 1", "resource_1", object)
rg.AddResource(r1)
r2 := New(cfgUsEast2, Ec2Image, "resource 2", "resource_2", object)
r2 := New(*cfgUsEast2, Ec2Image, "resource 2", "resource_2", object)
rg.AddResource(r2)
r3 := NewVersion(cfgUsEast1, Ec2Instance, "resource 3", "resource_3", "2", object)
rg.AddResource(r3)
Expand Down

0 comments on commit 93bc3fd

Please sign in to comment.