Fix filter bypass leading to XSS (#362) #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @terjanq:
I was able to reproduce this issue.
The proposed change ignores whitespace between the tag name and the
.+
and from my tests this seems to do the trick.However, I will admit that I'm not a security guy so it's possible that this change has it's own issues.
Furthermore, I was unable to reproduce the second example given in #362, so that might already have been fixed.