-
-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #2109
Conversation
Looks like |
As I said before, I would like to keep Python 3.6 compatibility in trezorlib for as long as it is not a burden. If including Python 3.6 in CI is problematic, we can drop it, but I'd keep it in tox and keep the package requirements as-is |
Reworked the PR to keep Py3.6 compatibility |
wasn't the previous version where pillow is 0.9 working for some reason? |
Pillow 0.9.x is not compatible with Py3.6 Pillow 0.8.4 works on my machine, Pillow 0.8.1 (originally suggested) doesn't. |
I don't understand why that is a problem in poetry env. Tox is not using that and we aren't either. |
One more force push - 7b62c92 - pyproject.toml set to Py3.7, trezorlib kept at 3.6 |
@mmilata any idea why pyright is now missing? |
do you maybe need to rerun the pyright generator script? https://github.com/trezor/trezor-firmware/blob/master/ci/pyright/README.md |
I tried it ... it refreshed lots of dependencies of pyright, but result is still the same - the environment does not have |
Looks like pyright gets built but for some reason the |
Ah, there's no |
Seems to be related to nodejs 14->16 update: NixOS/nixpkgs#145432. My attempt for workaround: 91182cf. Other possibility is to create the symlinks manually in |
Thanks, that did the trick. Cherry-picked and rebased and force-pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, though ti seems pylint became more stricter and fails: https://gitlab.com/satoshilabs/trezor/trezor-firmware/-/jobs/2083350519
more like pylint changed the ignore list format AGAIN 😠 i'll fix it later if nobody else beats me to it |
[no changelog] Co-Authored-By: Martin Milata <[email protected]>
0f67900
to
0dd06e9
Compare
it's actually still the same issue that prevented me from updating the last time: pylint-dev/pylint#5491 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI passes, let's merge.
No description provided.