Include a valid staging certificate for TS5 emulator #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Jun 12, 2024
|
|
||
| cryptography_version = [int(x) for x in cryptography.__version__.split(".")] | ||
| if cryptography_version[0] < 41: | ||
| raise ImportError("cryptography>=41 is required for this module") |
There was a problem hiding this comment.
nit:
Suggested change
| raise ImportError("cryptography>=41 is required for this module") | |
| raise ImportError(f"cryptography>=41 is required for this module, found cryptography=={cryptography.__version__}") |
mmilata
approved these changes
Jun 17, 2024
| @@ -0,0 +1,79 @@ | |||
| static const unsigned char T2B1_der[] = { | |||
| 0x30, 0x82, 0x01, 0x9f, 0x30, 0x82, 0x01, 0x45, 0xa0, 0x03, 0x02, 0x01, | |||
There was a problem hiding this comment.
make cstyle changes indent on the generated files
matejcik
force-pushed
the
matejcik/translation-versions
branch
from
70db3d5 to
ce24362
Compare
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
96d37a6 to
f924815
Compare
|
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
f924815 to
e774178
Compare
|
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
e774178 to
bf60ae7
Compare
Merged
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
f3d403c to
5623f6d
Compare
|
added certificate whitelist check in aab2eaf |
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
2b33189 to
bf22aa3
Compare
andrewkozlik
approved these changes
Jun 24, 2024
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
05480f1 to
2297cb7
Compare
matejcik
force-pushed
the
matejcik/emu-cert
branch
from
2297cb7 to
f6924c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3765
includes certificate verification code and supersedes #3464
@andrewkozlik please have a look, I believe all your comments from #3464 are applied here