fix(suite): handle estimated fee error (#11671)

trezor · May 14, 2024 · 32a42b1 · 32a42b1
1 parent edbc2ad
commit 32a42b1
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 45 deletions.
diff --git a/...es/suite/src/components/suite/notifications/NotificationRenderer/NotificationRenderer.tsx b/...es/suite/src/components/suite/notifications/NotificationRenderer/NotificationRenderer.tsx
@@ -134,6 +134,8 @@ export const NotificationRenderer = ({
             return error(render, notification, 'METADATA_PROVIDER_AUTH_ERROR');
         case 'metadata-unexpected-error':
             return error(render, notification, 'METADATA_PROVIDER_UNEXPECTED_ERROR');
+        case 'estimated-fee-error':
+            return info(render, notification, 'TOAST_ESTIMATED_FEE_ERROR');
         case 'auto-updater-error':
             return error(render, notification, 'TOAST_AUTO_UPDATER_ERROR', {
                 state: notification.state,

diff --git a/packages/suite/src/support/messages.ts b/packages/suite/src/support/messages.ts
@@ -8853,6 +8853,10 @@ export default defineMessages({
         id: 'TOAST_SUCCESSFUL_CLAIM',
         defaultMessage: '{symbol} claimed successfully',
     },
+    TOAST_ESTIMATED_FEE_ERROR: {
+        id: 'TOAST_ESTIMATED_FEE_ERROR',
+        defaultMessage: 'Fee estimation from network failed. Using backup value.',
+    },
     TR_STAKE_TOTAL_PENDING: {
         id: 'TR_STAKE_TOTAL_PENDING',
         defaultMessage: 'Total stake pending:',

diff --git a/suite-common/toast-notifications/src/types.ts b/suite-common/toast-notifications/src/types.ts
@@ -61,26 +61,29 @@ export type ToastPayload = (
               | 'sign-message-success'
               | 'verify-message-success'
               | 'firmware-check-authenticity-success'
-              | 'device-authenticity-success';
+              | 'device-authenticity-success'
+              | 'clear-storage'
+              | 'add-token-success'
+              | 'auto-updater-no-new'
+              | 'qr-incorrect-address'
+              | 'copy-to-clipboard'
+              | 'savings-kyc-failed'
+              | 'savings-kyc-success'
+              | 'tor-is-slow'
+              | 'coinjoin-interrupted'
+              | 'firmware-language-changed'
+              | 'firmware-language-fetch-error'
+              | 'estimated-fee-error';
       }
     | SentTransactionNotification
     | {
           type: 'raw-tx-sent';
           txid: string;
       }
-    | {
-          type: 'copy-to-clipboard';
-      }
-    | {
-          type: 'clear-storage';
-      }
     | {
           type: 'bridge-dev-restart';
           devMode: boolean;
       }
-    | {
-          type: 'add-token-success';
-      }
     | {
           type:
               | 'error'
@@ -94,16 +97,15 @@ export type ToastPayload = (
               | 'metadata-auth-error'
               | 'metadata-not-found-error'
               | 'metadata-unexpected-error'
-              | 'device-authenticity-error';
+              | 'device-authenticity-error'
+              | 'cardano-delegate-error'
+              | 'cardano-withdrawal-error';
           error: string;
       }
     | {
           type: 'auto-updater-error';
           state: DesktopAppUpdateState;
       }
-    | {
-          type: 'auto-updater-no-new';
-      }
     | {
           type: 'auto-updater-new-version-first-run';
           version: string;
@@ -115,49 +117,20 @@ export type ToastPayload = (
           type: 'qr-incorrect-coin-scheme-protocol';
           coin: string;
       }
-    | {
-          type: 'qr-incorrect-address';
-      }
     | {
           type: 'coin-scheme-protocol';
           scheme: PROTOCOL_SCHEME;
           address: string;
           amount?: number;
       }
-    | {
-          type: 'cardano-delegate-error';
-          error: string;
-      }
-    | {
-          type: 'cardano-withdrawal-error';
-          error: string;
-      }
-    | {
-          type: 'savings-kyc-failed';
-      }
-    | {
-          type: 'savings-kyc-success';
-      }
     | {
           type: 'tor-toggle-error';
           error: TranslationKey;
       }
-    | {
-          type: 'tor-is-slow';
-      }
-    | {
-          type: 'coinjoin-interrupted';
-      }
     | {
           type: 'successful-claim';
           symbol: string;
       }
-    | {
-          type: 'firmware-language-changed';
-      }
-    | {
-          type: 'firmware-language-fetch-error';
-      }
     | StakedTransactionNotification
     | UnstakedTransactionNotification
     | ClaimedTransactionNotification

diff --git a/suite-common/wallet-core/src/send/sendFormEthereumThunks.ts b/suite-common/wallet-core/src/send/sendFormEthereumThunks.ts
@@ -110,7 +110,7 @@ const calculate = (
 
 export const composeEthereumSendFormTransactionThunk = createThunk(
     `${SEND_MODULE_PREFIX}/composeEthereumSendFormTransactionThunk`,
-    async ({ formValues, formState }: ComposeTransactionThunkArguments) => {
+    async ({ formValues, formState }: ComposeTransactionThunkArguments, { dispatch }) => {
         const { account, network, feeInfo } = formState;
         const composeOutputs = getExternalComposeOutput(formValues, account, network);
         if (!composeOutputs) return; // no valid Output
@@ -151,7 +151,11 @@ export const composeEthereumSendFormTransactionThunk = createThunk(
         } else {
             customFeeLimit = tokenInfo ? ERC20_BACKUP_GAS_LIMIT : ETH_BACKUP_GAS_LIMIT;
 
-            // TODO: catch error from blockbook/geth (invalid contract, not enough balance...)
+            dispatch(
+                notificationsActions.addToast({
+                    type: 'estimated-fee-error',
+                }),
+            );
         }
 
         // FeeLevels are read-only