fix(trade): analytics event

trezor · Oct 21, 2024 · 560dd75 · 560dd75
1 parent 324ba30
commit 560dd75
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/packages/suite-analytics/src/constants.ts b/packages/suite-analytics/src/constants.ts
@@ -17,6 +17,8 @@ export enum EventType {
 
     AppUriHandler = 'app/uri-handler',
 
+    DashboardActions = 'dashboard/actions',
+
     DeviceConnect = 'device-connect',
     DeviceDisconnect = 'device-disconnect',
     DeviceUpdateFirmware = 'device-update-firmware',
@@ -48,7 +50,6 @@ export enum EventType {
     MenuGuide = 'menu/guide',
     MenuNotificationsToggle = 'menu/notifications/toggle',
     MenuToggleDiscreet = 'menu/toggle-discreet',
-    MenuActions = 'menu/actions',
 
     GuideHeaderNavigation = 'guide/header/navigation',
     GuideNodeNavigation = 'guide/node/navigation',

diff --git a/packages/suite-analytics/src/types/events.ts b/packages/suite-analytics/src/types/events.ts
@@ -52,6 +52,12 @@ export type SuiteAnalyticsEvent =
               isAmountPresent: boolean;
           };
       }
+    | {
+          type: EventType.DashboardActions;
+          payload: {
+              type: string;
+          };
+      }
     | {
           type: EventType.DeviceConnect;
           payload: {
@@ -224,12 +230,6 @@ export type SuiteAnalyticsEvent =
     | {
           type: EventType.MenuGuide;
       }
-    | {
-          type: EventType.MenuActions;
-          payload: {
-              type: string;
-          };
-      }
     | {
           type: EventType.GuideHeaderNavigation;
           payload: {

diff --git a/packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/TradeActions.tsx b/packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/TradeActions.tsx
@@ -10,7 +10,7 @@ import { HeaderActionButton } from 'src/components/suite/layouts/SuiteLayout/Pag
 import { selectDevice } from '@suite-common/wallet-core';
 import { spacings } from '@trezor/theme';
 import { SelectedAccountStatus } from '@suite-common/wallet-types';
-import { selectIsAccountTabPage } from 'src/reducers/suite/routerReducer';
+import { selectIsAccountTabPage, selectRouteName } from 'src/reducers/suite/routerReducer';
 
 // instant without computing the layout
 const ShowOnLargeDesktopWrapper = styled.div<{ $isActive?: boolean }>`
@@ -35,11 +35,12 @@ export const TradeActions = ({
     const account = selectedAccount?.account;
     const device = useSelector(selectDevice);
     const isAccountTabPage = useSelector(selectIsAccountTabPage);
+    const currentRouteName = useSelector(selectRouteName);
 
     const goToWithAnalytics = (...[routeName, options]: Parameters<typeof goto>) => {
-        if (routeName === 'suite-index') {
+        if (currentRouteName === 'suite-index') {
             analytics.report({
-                type: EventType.MenuActions,
+                type: EventType.DashboardActions,
                 payload: { type: routeName },
             });
         }