feat(mobile): remote feature flag for FW update

trezor · Jan 15, 2025 · 8aee1e5 · 8aee1e5
1 parent 7332d2f
commit 8aee1e5
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 10 deletions.
diff --git a/suite-common/message-system/src/messageSystemTypes.ts b/suite-common/message-system/src/messageSystemTypes.ts
@@ -25,6 +25,8 @@ export const Feature = {
     ethClaim: 'eth.staking.claim',
     firmwareRevisionCheck: 'security.firmware.check',
     firmwareHashCheck: 'security.firmware.hashCheck',
+    // FW update feature flag implemented only for mobile app
+    firmwareUpdate: 'device.firmware.update',
 } as const;
 
 export type FeatureDomain = (typeof Feature)[keyof typeof Feature];

diff --git a/suite-native/feature-flags/src/featureFlagsSlice.ts b/suite-native/feature-flags/src/featureFlagsSlice.ts
@@ -8,7 +8,6 @@ export const FeatureFlag = {
     IsCardanoSendEnabled: 'isCardanoSendEnabled',
     IsRegtestEnabled: 'isRegtestEnabled',
     IsConnectPopupEnabled: 'IsConnectPopupEnabled',
-    IsFirmwareUpdateEnabled: 'IsFirmwareUpdateEnabled',
     AreEthL2sEnabled: 'AreEthL2sEnabled',
 } as const;
 export type FeatureFlag = (typeof FeatureFlag)[keyof typeof FeatureFlag];
@@ -24,7 +23,6 @@ export const featureFlagsInitialState: FeatureFlagsState = {
     [FeatureFlag.IsCardanoSendEnabled]: isAndroid() && isDevelopOrDebugEnv(),
     [FeatureFlag.IsRegtestEnabled]: isDebugEnv() || isDetoxTestBuild(),
     [FeatureFlag.IsConnectPopupEnabled]: isDevelopOrDebugEnv(),
-    [FeatureFlag.IsFirmwareUpdateEnabled]: isDevelopOrDebugEnv(),
     [FeatureFlag.AreEthL2sEnabled]: isDebugEnv(),
 };
 
@@ -33,7 +31,6 @@ export const featureFlagsPersistedKeys: Array<keyof FeatureFlagsState> = [
     FeatureFlag.IsCardanoSendEnabled,
     FeatureFlag.IsRegtestEnabled,
     FeatureFlag.IsConnectPopupEnabled,
-    FeatureFlag.IsFirmwareUpdateEnabled,
     FeatureFlag.AreEthL2sEnabled,
 ];
 

diff --git a/suite-native/firmware/package.json b/suite-native/firmware/package.json
@@ -16,6 +16,7 @@
         "@shopify/react-native-skia": "^1.5.10",
         "@suite-common/firmware": "workspace:*",
         "@suite-common/icons": "workspace:*",
+        "@suite-common/message-system": "workspace:*",
         "@suite-native/link": "workspace:*",
         "@trezor/connect": "workspace:*",
         "@trezor/react-native-usb": "workspace:*",

diff --git a/suite-native/firmware/src/hooks/useIsFirmwareUpdateFeatureEnabled.tsx b/suite-native/firmware/src/hooks/useIsFirmwareUpdateFeatureEnabled.tsx
@@ -0,0 +1,15 @@
+import { useSelector } from 'react-redux';
+
+import {
+    selectIsFeatureEnabled,
+    Feature,
+    MessageSystemRootState,
+} from '@suite-common/message-system';
+
+export const useIsFirmwareUpdateFeatureEnabled = () => {
+    const isFirmwareUpdateEnabled = useSelector((state: MessageSystemRootState) =>
+        selectIsFeatureEnabled(state, Feature.firmwareUpdate, true),
+    );
+
+    return isFirmwareUpdateEnabled;
+};
diff --git a/suite-native/firmware/src/index.ts b/suite-native/firmware/src/index.ts
@@ -1,3 +1,4 @@
 export * from './nativeFirmwareSlice';
 export * from './components/UpdateProgressIndicatorDemo';
 export * from './screens/FirmwareUpdateInProgressScreen';
+export * from './hooks/useIsFirmwareUpdateFeatureEnabled';
diff --git a/suite-native/firmware/tsconfig.json b/suite-native/firmware/tsconfig.json
@@ -4,6 +4,9 @@
     "references": [
         { "path": "../../suite-common/firmware" },
         { "path": "../../suite-common/icons" },
+        {
+            "path": "../../suite-common/message-system"
+        },
         { "path": "../link" },
         { "path": "../../packages/connect" },
         {

diff --git a/suite-native/module-device-settings/src/components/DeviceFirmwareCard.tsx b/suite-native/module-device-settings/src/components/DeviceFirmwareCard.tsx
@@ -24,7 +24,7 @@ import {
     DeviceSettingsStackParamList,
 } from '@suite-native/navigation';
 import { isDevelopOrDebugEnv } from '@suite-native/config';
-import { FeatureFlag, useFeatureFlag } from '@suite-native/feature-flags';
+import { useIsFirmwareUpdateFeatureEnabled } from '@suite-native/firmware';
 
 import { DeviceSettingsCardLayout } from './DeviceSettingsCardLayout';
 
@@ -66,7 +66,7 @@ export const DeviceFirmwareCard = () => {
         selectIsDiscoveryActiveByDeviceState(state, device?.state),
     );
     const navigation = useNavigation<NavigationProp>();
-    const isFirmwareUpdateEnabled = useFeatureFlag(FeatureFlag.IsFirmwareUpdateEnabled);
+    const isFirmwareUpdateEnabled = useIsFirmwareUpdateFeatureEnabled();
 
     if (!device || !deviceModel) {
         return null;

diff --git a/...e-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareUpdateScreen.tsx b/...e-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareUpdateScreen.tsx
@@ -20,7 +20,7 @@ import {
     selectDeviceState,
 } from '@suite-common/wallet-core';
 import { useAlert } from '@suite-native/alerts';
-import { FeatureFlag, useFeatureFlag } from '@suite-native/feature-flags';
+import { useIsFirmwareUpdateFeatureEnabled } from '@suite-native/firmware';
 
 import { FirmwareUpdateVersionCard } from './FirmwareVersionCard';
 
@@ -43,7 +43,7 @@ export const FirmwareUpdateScreen = () => {
     const isDiscoveryRunning = useSelector((state: DiscoveryRootState & DeviceRootState) =>
         selectIsDiscoveryActiveByDeviceState(state, deviceState),
     );
-    const isFirmwareUpdateEnabled = useFeatureFlag(FeatureFlag.IsFirmwareUpdateEnabled);
+    const isFirmwareUpdateEnabled = useIsFirmwareUpdateFeatureEnabled();
 
     const handleShowSeedBottomSheet = useCallback(() => {
         showAlert({
@@ -68,7 +68,7 @@ export const FirmwareUpdateScreen = () => {
                 <Button
                     onPress={handleShowSeedBottomSheet}
                     style={applyStyle(firmwareUpdateButtonStyle)}
-                    isDisabled={isDiscoveryRunning || isFirmwareUpdateEnabled}
+                    isDisabled={isDiscoveryRunning || !isFirmwareUpdateEnabled}
                     isLoading={isDiscoveryRunning}
                 >
                     <Translation id="moduleDeviceSettings.firmware.firmwareUpdateScreen.updateButton" />

diff --git a/suite-native/module-home/src/screens/HomeScreen/components/FirmwareUpdateAlert.tsx b/suite-native/module-home/src/screens/HomeScreen/components/FirmwareUpdateAlert.tsx
@@ -26,7 +26,7 @@ import {
     DeviceStackRoutes,
 } from '@suite-native/navigation';
 import { Translation } from '@suite-native/intl';
-import { FeatureFlag, useFeatureFlag } from '@suite-native/feature-flags';
+import { useIsFirmwareUpdateFeatureEnabled } from '@suite-native/firmware';
 
 const containerStyle = prepareNativeStyle(utils => ({
     flexDirection: 'row',
@@ -76,7 +76,7 @@ export const FirmwareUpdateAlert = () => {
     );
 
     const isClosed = useAtomValue(isClosedAtom);
-    const isFirmwareUpdateEnabled = useFeatureFlag(FeatureFlag.IsFirmwareUpdateEnabled);
+    const isFirmwareUpdateEnabled = useIsFirmwareUpdateFeatureEnabled();
 
     const isUpgradable = deviceReleaseInfo?.isNewer;
 

diff --git a/yarn.lock b/yarn.lock
@@ -10337,6 +10337,7 @@ __metadata:
     "@shopify/react-native-skia": "npm:^1.5.10"
     "@suite-common/firmware": "workspace:*"
     "@suite-common/icons": "workspace:*"
+    "@suite-common/message-system": "workspace:*"
     "@suite-native/link": "workspace:*"
     "@trezor/connect": "workspace:*"
     "@trezor/react-native-usb": "workspace:*"